Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow VECT_TAB_OFFSET to be set externally #4

Open
armandas opened this issue Aug 12, 2022 · 4 comments
Open

Allow VECT_TAB_OFFSET to be set externally #4

armandas opened this issue Aug 12, 2022 · 4 comments
Assignees
Labels
cmsis CMSIS-related issue or pull-request. enhancement New feature or request internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system.

Comments

@armandas
Copy link

Currently, in order to change the value of VECT_TAB_OFFSET, the user has to modify the system_stm32h7xx.c file. This is inconvenient in cases where the value has to change for different builds.

If the code was changed from:

#define VECT_TAB_OFFSET         0x00000000U

to

#ifndef VECT_TAB_OFFSET
#define VECT_TAB_OFFSET         0x00000000U
#endif

The user could define the value via a command line, like so -DVECT_TAB_OFFSET=0x00020000.

@ALABSTM ALABSTM self-assigned this Aug 24, 2022
@utkarshsethi
Copy link

@ALABSTM I think this is duplicate/would also fix STMicroelectronics/cmsis-device-g4#1

@HBOSTM HBOSTM added the cmsis CMSIS-related issue or pull-request. label Feb 21, 2023
@ALABSTM ALABSTM added the enhancement New feature or request label Oct 12, 2023
@okz
Copy link

okz commented Oct 18, 2023

not being able to define this externally, or having this inside a user block, is a real inconvenience, especially when developing seperate boot / application firmware.

It's are really small fix, is there a reason for not implementing it yet?

@ALABSTM
Copy link
Collaborator

ALABSTM commented Nov 29, 2023

Hi everyone,

@armandas, thank you for having reported. We already logged the point internally and are working on it, among many other points.

@utkarshsethi, you're absolutely right. This is the same issue as the one you mentioned. However, as the repos are different, we will keep track of them separately.

@okz, I understand your point. We will try to have this fix implemented, deployed, and released soon enough hopefully.

Thank you all for your patience and your comprehension.

With regards,

@ALABSTM
Copy link
Collaborator

ALABSTM commented Nov 29, 2023

ST Internal Reference: 116475

@ALABSTM ALABSTM added the internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system. label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmsis CMSIS-related issue or pull-request. enhancement New feature or request internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system.
Projects
Development

No branches or pull requests

5 participants