Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong place for DUAL_CORE check in stm32h7xx.h #19

Open
HiFiPhile opened this issue Jan 28, 2025 · 0 comments
Open

Wrong place for DUAL_CORE check in stm32h7xx.h #19

HiFiPhile opened this issue Jan 28, 2025 · 0 comments
Assignees
@TOUNSTM
Labels
bug Something isn't working cmsis CMSIS-related issue or pull-request.

Comments

@HiFiPhile
Copy link

Describe the bug

In stm32h7xx.h

DUAL_CORE check is placed above inclusion of device specific header files:
https://github.com/STMicroelectronics/cmsis-device-h7/blame/e8d40ae6e2fa06afe5b46d24756f141b363342a7/Include/stm32h7xx.h#L92

SInce DUAL_CORE is not yet defined, this check is meaningless.

Solution

Move this check to line 172.
@ALABSTM ALABSTM added bug Something isn't working cmsis CMSIS-related issue or pull-request. labels Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TOUNSTM TOUNSTM

Labels
bug Something isn't working cmsis CMSIS-related issue or pull-request.
Projects
stm32cube-mcu-cmsis-dashboard
Status: To do
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HiFiPhile @ALABSTM @TOUNSTM