Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new_handler must throw std::bad_alloc or something derived from it. #6542

Closed
hkaiser opened this issue Sep 11, 2024 · 0 comments · Fixed by #6543
Closed

new_handler must throw std::bad_alloc or something derived from it. #6542

hkaiser opened this issue Sep 11, 2024 · 0 comments · Fixed by #6543
Labels
type: defect

Comments

@hkaiser
Copy link
Member

hkaiser commented Sep 11, 2024

Currently our new_handler that is invoked in OOM contexts throws an hpx::exception (see

hpx/libs/core/runtime_local/src/runtime_local.cpp

Lines 230 to 234 in f4ff6e8

[[noreturn]] HPX_CORE_EXPORT void HPX_CDECL new_handler()
{
HPX_THROW_EXCEPTION(hpx::error::out_of_memory, "new_handler",
"new allocator failed to allocate memory");
}
). This is UB.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Throwing an exception derived from std::bad_alloc on OOM conditions STEllAR-GROUP/hpx
1 participant
@hkaiser