Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some DialogViewModelBase does not register Subscriptions #1377

Open
antoineatstariongroup opened this issue Feb 14, 2025 · 0 comments
Open

Some DialogViewModelBase does not register Subscriptions #1377

antoineatstariongroup opened this issue Feb 14, 2025 · 0 comments

Comments

@antoineatstariongroup
Copy link
Contributor

For example, in the DataSourceSelectionViewModel, all subscriptions to reactive property are not added to the Subsprictions collection (list that collects all IDisposable that should be disposed).

Not added them into the collection leads in memory leak since those subscriptions are still alive, even if the ViewModel is not used anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
COMET-CE
Status: To Be Estimated
Milestone
No milestone
Development

No branches or pull requests
1 participant
@antoineatstariongroup