-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nightly warnings related to lifetimes #1
Conversation
The following warnings appear: ``` src/lib.rs:73:5: 73:68 warning: the trait `core::marker::Sized` is not implemented for the type `Self` [E0277] src/lib.rs:73 unsafe fn call_block<R>(self, block: *mut Block<Self, R>) -> R; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/lib.rs:73:5: 73:68 help: run `rustc --explain E0277` to see a detailed explanation src/lib.rs:73:5: 73:68 note: `Self` does not have a constant size known at compile-time src/lib.rs:73 unsafe fn call_block<R>(self, block: *mut Block<Self, R>) -> R; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/lib.rs:73:5: 73:68 note: this warning results from recent bug fixes and clarifications; it will become a HARD ERROR in the next release. See RFC 1214 for details. src/lib.rs:73 unsafe fn call_block<R>(self, block: *mut Block<Self, R>) -> R; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/lib.rs:73:5: 73:68 note: required by `Block` src/lib.rs:73 unsafe fn call_block<R>(self, block: *mut Block<Self, R>) -> R; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/lib.rs:187:5: 187:71 warning: the trait `core::marker::Sized` is not implemented for the type `Self` [E0277] src/lib.rs:187 fn into_concrete_block(self) -> ConcreteBlock<A, Self::Ret, Self>; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/lib.rs:187:5: 187:71 help: run `rustc --explain E0277` to see a detailed explanation src/lib.rs:187:5: 187:71 note: `Self` does not have a constant size known at compile-time src/lib.rs:187 fn into_concrete_block(self) -> ConcreteBlock<A, Self::Ret, Self>; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/lib.rs:187:5: 187:71 note: this warning results from recent bug fixes and clarifications; it will become a HARD ERROR in the next release. See RFC 1214 for details. src/lib.rs:187 fn into_concrete_block(self) -> ConcreteBlock<A, Self::Ret, Self>; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/lib.rs:187:5: 187:71 note: required by `ConcreteBlock` src/lib.rs:187 fn into_concrete_block(self) -> ConcreteBlock<A, Self::Ret, Self>; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` ...because of: rust-lang/rfcs#1214
Thank you @frewsxcv! I'll publish a new version to crates.io later. |
Great, thanks! |
Can you respond here when you end up bumping the version? A couple projects I work on (including Servo) rely on this so it'd be nice to get rid of the warning |
@frewsxcv, updated it now! I didn't realize anyone was using this project; I found rust-clipboard, is anything else? |
Servo uses rust-clipboard, and one of my internal projects also uses rust-clipboard. not sure about others |
Upgrade rust-block to silence warning SSheldon/rust-block#1 Relevant to #7513 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7526) <!-- Reviewable:end -->
…sxcv:bump-no-warnings); r=jdm SSheldon/rust-block#1 Relevant to servo/servo#7513 Source-Repo: https://github.com/servo/servo Source-Revision: 3a09c027e2f19b3b0fdf0b55730532b942103411
…sxcv:bump-no-warnings); r=jdm SSheldon/rust-block#1 Relevant to servo/servo#7513 Source-Repo: https://github.com/servo/servo Source-Revision: 3a09c027e2f19b3b0fdf0b55730532b942103411 UltraBlame original commit: 7717e8aa23d6cd1dfb920b17dd0753b82b1841be
…sxcv:bump-no-warnings); r=jdm SSheldon/rust-block#1 Relevant to servo/servo#7513 Source-Repo: https://github.com/servo/servo Source-Revision: 3a09c027e2f19b3b0fdf0b55730532b942103411 UltraBlame original commit: 7717e8aa23d6cd1dfb920b17dd0753b82b1841be
…sxcv:bump-no-warnings); r=jdm SSheldon/rust-block#1 Relevant to servo/servo#7513 Source-Repo: https://github.com/servo/servo Source-Revision: 3a09c027e2f19b3b0fdf0b55730532b942103411 UltraBlame original commit: 7717e8aa23d6cd1dfb920b17dd0753b82b1841be
The following warnings appear:
...because of:
rust-lang/rfcs#1214