Skip to content

Commit a88567e

Browse files
✨ Developing PerturbationMatrix class (#59)
* ✨ Developing PerturbationMatrix class * ✅ fixing flake8 * ✨ added a 3D matrix * 🎨 fairly good sketch * Update src/psfmachine/perturbation.py Co-authored-by: Jorge Martínez-Palomera <[email protected]> * Update src/psfmachine/perturbation.py * fixing identation and _clean_vectors when segments=True * ⚡ faster! * 🎨 adding pixel masking * 📝 added docstrings * ✨ Added PCA method * 🎨 added fbpca explicitly as dependency * 📝 docs * 🐛 fixing pca * 🐛 fix @jorgemarpa bug * 📝 update docstrings * Update src/psfmachine/perturbation.py Co-authored-by: Jorge Martínez-Palomera <[email protected]> * ✨ now pca has smoothed components * 🐛 update pca * 🎨 flake8 * 🎨 no comment block * 📝 docstrings * 🎨 updating sane defaults, adding smooth PCA components * 🎨 sane defaults * 📝 documentation Co-authored-by: Jorge Martínez-Palomera <[email protected]> Co-authored-by: Jorge <[email protected]>
1 parent 9b3a961 commit a88567e

File tree

5 files changed

+781
-40
lines changed

5 files changed

+781
-40
lines changed

poetry.lock

Lines changed: 0 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/psfmachine/machine.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -887,7 +887,7 @@ def build_time_model(self, plot=False, downsample=False, split_time_model=False)
887887
dy,
888888
n_knots=self.n_time_knots,
889889
radius=self.time_radius,
890-
spacing=self.cartesian_knot_spacing,
890+
knot_spacing_type=self.cartesian_knot_spacing,
891891
)
892892
A2 = sparse.vstack([A_c] * time_binned.shape[0], format="csr")
893893
# Cartesian spline with time dependence
@@ -1049,7 +1049,7 @@ def plot_time_model(self, segment=0):
10491049
dy,
10501050
n_knots=self.n_time_knots,
10511051
radius=self.time_radius,
1052-
spacing=self.cartesian_knot_spacing,
1052+
knot_spacing_type=self.cartesian_knot_spacing,
10531053
)
10541054
# if self.seg_splits.shape[0] == 2 and segment == 0:
10551055
# seg_mask = np.ones(time_binned.shape[0], dtype=bool)
@@ -1576,7 +1576,7 @@ def fit_model(self, fit_va=False):
15761576
dy,
15771577
n_knots=self.n_time_knots,
15781578
radius=self.time_radius,
1579-
spacing=self.cartesian_knot_spacing,
1579+
knot_spacing_type=self.cartesian_knot_spacing,
15801580
)
15811581
A_cp3 = sparse.hstack([A_cp, A_cp, A_cp, A_cp], format="csr")
15821582

0 commit comments

Comments
 (0)