Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change sidenav to highlight first and not last item if content smaller than screensize #129

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

CharlRitterDev
Copy link
Contributor

feature: Change sidenav to highlight first and not last item if content smaller than screensize

Description

feature: Change sidenav to highlight first and not last item if content smaller than screensize

Issue

Screenshots

Checklist before merging

  • Is this code covered by tests?
  • Is the documentation updated for this change?

@CharlRitterDev CharlRitterDev requested a review from a team as a code owner July 24, 2024 14:45
Copy link
Contributor

@Zalaras Zalaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test locally and is highlighting correctly.

Update PR title to use fix:

@CharlRitterDev CharlRitterDev changed the title feature: Change sidenav to highlight first and not last item if content smaller than screensize fix: Change sidenav to highlight first and not last item if content smaller than screensize Jul 25, 2024
Copy link
Contributor

@Zalaras Zalaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broke the menu auto opening when scrolling down through sections

Copy link
Contributor

@Zalaras Zalaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK working now :)

@CharlRitterDev CharlRitterDev merged commit 245e0ac into develop Jul 25, 2024
1 check passed
@CharlRitterDev CharlRitterDev deleted the scrollspy-fix branch July 25, 2024 09:37
Zalaras pushed a commit that referenced this pull request Jul 25, 2024
## [2.13.2-rfv.4](v2.13.2-rfv.3...v2.13.2-rfv.4) (2024-07-25)

### Bug Fixes

* Change sidenav to highlight first and not last item if content smaller than screensize ([#129](#129)) ([245e0ac](245e0ac))
@Zalaras
Copy link
Contributor

Zalaras commented Jul 25, 2024

🎉 This PR is included in version 2.13.2-rfv.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants