[FIX/#50] 홈화면 QA 해결 #51
Merged
+90
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boiledEgg-s
requested review from
yihwanggeun,
chrin05 and
jangsjw
and removed request for
a team
|
고생하셨습니다~!! |
jangsjw
approved these changes
Nov 28, 2024
yihwanggeun
approved these changes
Nov 28, 2024
|
|
||
| fun NavGraphBuilder.homeScreen( | ||
| navController: NavHostController, | ||
| modifier: Modifier = Modifier | ||
| ) { | ||
| composable<Home> { | ||
| composable<Home>( |
There was a problem hiding this comment.
애니메이션 삭제해서 문제를 해결한건가요??
There was a problem hiding this comment.
그 부분은 메인화면에서 바텀바로 화면 전환할 때 fade 효과가 싫어서 없앤거에요!
QA 건이 아니라 그냥 제 개인적인 욕심에 의해 적용한겁니다ㅎㅎ
| elevation = CardDefaults.elevatedCardElevation(defaultElevation = 10.dp), | ||
| shape = RectangleShape, | ||
| modifier = Modifier.showIf(visibility) | ||
| AnimatedVisibility( |
There was a problem hiding this comment.
그냥 if문 쓰면 바텀바가 깜박이는게 안없어지더라구요,,
저도 애니메이션이 익숙하진 않아서 좀더 알아봐야겠어요,,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
HomeScreenQA.mp4
Uncompleted Tasks 😅
To Reviewers (Optional) 📢
AnimatedVisibility로 해결 - 37ed1eelaunchSingleTop을 true로 설정하여 해결 - be5a817이상입니다~ 난 끝!