[Feat/#23] "좌석 선택 뷰", "승차권 확인 뷰" 서버통신 구현 #24
+612
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitsuhyun
approved these changes
Nov 29, 2024
| } | ||
|
|
||
| LaunchedEffect(viewModel.leftSeatsState) { | ||
| snapshotFlow { viewModel.leftSeatsState.value } |
There was a problem hiding this comment.
[3]
저는 collectAsState를 사용했는데 snapshotFlow라는 것을 사용해서 flow를 관찰할 수도 있군용
Comment on lines
+106
to
+107
| items(seatsMapData.size) { index -> | ||
| val coach = seatsMapData[index] |
There was a problem hiding this comment.
[3]
itemsIndexed를 사용하면 index, item을 반환할 수 있더라구요!
Comment on lines
+21
to
39
| private val ticketRepository: TicketRepository | ||
| ) : ViewModel() { | ||
| var showDialog = mutableStateOf(false) | ||
| private var _ticketState = MutableStateFlow<TicketState>(TicketState.Idle) | ||
| val ticketState: StateFlow<TicketState> = _ticketState | ||
|
|
||
| val ticketDummy = TicketData( | ||
| departurePlace = "서울", | ||
| arrivalPlace = "부산", | ||
| date = "2024년 10월 30일 (수)", | ||
| trainName = "KTX 001", | ||
| departureTime = "09:30", | ||
| arrivalTime = "12:45", | ||
| seatName = "16A", | ||
| ticketPrice = 50000, | ||
| limitPaymentTime = formatDate(), | ||
| coachesNumber = 4 | ||
| private val _ticketData = MutableStateFlow<TicketData>( | ||
| TicketData( | ||
| departurePlace = "", | ||
| arrivalPlace = "", | ||
| date = "", | ||
| trainName = "", | ||
| departureTime = "", | ||
| arrivalTime = "", | ||
| seatName = "", | ||
| ticketPrice = 0, | ||
| limitPaymentTime = "", | ||
| coachesNumber = 0 | ||
| ) | ||
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
https://rumbling-chip-236.notion.site/23-14db4062d9c980f8b5d2e955a5cfe32b?pvs=4
Uncompleted Tasks 😅
To Reviewers 📢
정리해주신 것 바탕으로 clean architecutre와 repository 구조를 이해하려고 공부했습니다! viewModel에서는 model을 따로 정의해야하는지, domain의 model을 사용해도 의존성 규칙을 지키는지 궁금합니다..! 현재 코드에서는 domain의 모델을 viewModel에서 사용중입니다.