Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<nop> overrides the call::last_action_result, causing the call to succeed even if an action before it failed #765

Open
tghosgor opened this issue Oct 10, 2024 · 1 comment
Open

<nop> overrides the call::last_action_result, causing the call to succeed even if an action before it failed #765

tghosgor opened this issue Oct 10, 2024 · 1 comment

Comments

@tghosgor
Copy link
Contributor

Even if an <ereg check_it="true" marks the call for failure, a <nop> after it clears the error state, causing a false success.
@tghosgor
Copy link
Contributor Author

tghosgor commented Oct 10, 2024 •
edited
Loading

Created #766 as a proposal. I am not sure if it would break something else. I could add test cases if it looks fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tghosgor