-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalidate flow field cache entry when cost field changes #1679
Comments
Depends on #1656 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I have mostly finished a preliminary draft of this task, including separating out a FieldCache class. It is my first work with c++, but if you're good with me opening a pull request that may need a good bit of revision, I can push it on my lunch break or later today. I still need to get a test set up properly as well. If you'd like to see that before I even bother with pushing, let me know. |
I took the approach of passing in an optional clear_cache flag as a parameter (defaulting to false) into the functions that access the FieldCache inside the integrator. This might not be the best way to do it. I chose to use the openage::time::time_t class to force myself to understand it, as I hope to move to the history issue next, which uses curves. A FieldCost is marked as dirty if the latest change has happened AFTER the time_t parameter. |
@dmwever Yeah don't worry, you can just open a merge request and improve it along the way. Actually, if you want early feedback it's even better to publish it early as a draft. |
Required Skills: C++
Difficulty: Easy
The openage pathfinder uses flow fields to search for a path on the pathfinding grids (please read the documentation to familiarize yourself with the concepts). To avoid unnecessary computations, fields are cached and reused for similar paths.
Currently, flow fields in the cache never get invalidated or updated when the costs of cells on the grid change, so these changes are never reflected in path requests when using the cached fields. This also means that dynamic changes to the grid are also not possible at the moment which is a huge downsight. A dynamic grid is required for a lot of gameplay features (e.g. placing buildings, change in terrain), so cache invalidation should be implement as soon as possible.
The easiest way to address this issue is to mark sectors/cost fields that have changed as "dirty" and then evict and recompute the flow fields for them when a new path is requested.
To try out the current pathfinder, check out pathfinding demo 1 by running the following command:
Tasks:
CostField
as dirty. The easiest way to do this is to use abool
flag but you can also use theopenage::time::time_t
type to record the time of the last change.is_dirty(..)
toCostField
andSector
that checks if the cost field or sector are dirty at the specified time.Integrator
class. If it is dirty, the cached value should be evicted and recomputed.FieldCache
to make the code a bit more structured.Further Reading
openage::path
pathfinding moduleThe text was updated successfully, but these errors were encountered: