Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clang-tidy to buildsystem checks #1060

Open
Vtec234 opened this issue Oct 19, 2018 · 5 comments · May be fixed by #1710
Open

Add clang-tidy to buildsystem checks #1060

Vtec234 opened this issue Oct 19, 2018 · 5 comments · May be fixed by #1710
Labels
area: buildsystem Related to our cmake/python buildsystem code quality Does not alter behavior, but beauty of our code good first issue Suitable for newcomers just do it You can start working on this, there should be nothing left to discuss lang: python Done in Python code

Comments

@Vtec234
Copy link
Contributor

Vtec234 commented Oct 19, 2018

clang-tidy can detect lots of C++ programming and style errors, so it would be worthwile to have it included in make check. To do so, a Python module invoking it should be added to buildsystem.codecompliance.
@TheJJ TheJJ added area: buildsystem Related to our cmake/python buildsystem lang: python Done in Python code code quality Does not alter behavior, but beauty of our code good first issue Suitable for newcomers just do it You can start working on this, there should be nothing left to discuss labels Oct 19, 2018
kev946 added a commit to kev946/openage that referenced this issue Oct 20, 2018
@kev946
Add clang-tidy to buildsystem checks
e20ec3f 
Fixes SFTtech#1060
@kev946 kev946 mentioned this issue Oct 20, 2018
Closed
simonsan pushed a commit to simonsan-contrib/openage that referenced this issue Jun 20, 2019
@kev946 @simonsan
Add clang-tidy to buildsystem checks
a85d6aa 
Fixes SFTtech#1060
simonsan pushed a commit to simonsan-contrib/openage that referenced this issue Sep 24, 2019
@kev946 @simonsan
Add clang-tidy to buildsystem checks
8602827 
Fixes SFTtech#1060
simonsan added a commit to simonsan-contrib/openage that referenced this issue Sep 24, 2019
@simonsan
Fix clang-tidy error messages
1417a76 
Fixes SFTtech#1060
@simonsan simonsan mentioned this issue Sep 25, 2019
Closed
3 tasks
simonsan pushed a commit to simonsan-contrib/openage that referenced this issue Oct 8, 2019
@kev946 @simonsan
Add clang-tidy to buildsystem checks
1eecd72 
Fixes SFTtech#1060
simonsan pushed a commit to simonsan-contrib/openage that referenced this issue May 1, 2020
@kev946 @simonsan
Add clang-tidy to buildsystem checks
2445228 
Fixes SFTtech#1060
@TheJJ TheJJ moved this to clang-tidy related in openage code quality Feb 27, 2023
@heinezen heinezen moved this to code quality in openage beginner tasks Sep 10, 2023
@mcdermott111
Copy link

I would be interested in picking up this issue

@heinezen
Copy link
Member

@mcdermott111 You are very welcome to do that :)

@mcdermott111
Copy link

What is the best way to decide which clang-tidy errors to be checking for. I think it would be unnecessary to have every single error turned on. The following are the set of errors I was thinking of including so far: clang-analyzer, bugprone, concurrency, performance and their respective sub-errors.
Here is the list of all clang-tidy errors: https://clang.llvm.org/extra/clang-tidy/checks/list.html

@heinezen
Copy link
Member

@mcdermott111 I think these are good choices. We can always be more thorough later if we want.

@heinezen heinezen added the hacktoberfest For newcomers from Hacktoberfest event label Sep 20, 2024
@haytham918
Copy link

I can do this

@haytham918 haytham918 linked a pull request Nov 18, 2024 that will close this issue
Open
@heinezen heinezen linked a pull request Nov 18, 2024 that will close this issue
Add and Test Clang-tidy #1710
Open
@heinezen heinezen removed the hacktoberfest For newcomers from Hacktoberfest event label Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: buildsystem Related to our cmake/python buildsystem code quality Does not alter behavior, but beauty of our code good first issue Suitable for newcomers just do it You can start working on this, there should be nothing left to discuss lang: python Done in Python code
Projects
openage beginner tasks
Status: code quality
openage code quality
Status: clang-tidy related
Milestone
No milestone
5 participants
@TheJJ @heinezen @Vtec234 @mcdermott111 @haytham918