You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it'll be good to pin specific ImGui commit (I'll use release ones in "master" and releases) and allow to not specify IMGUI_DIR, but get ImGui from subrepository and be sure that the version you'll be using was tested with ImGui-SFML.
The text was updated successfully, but these errors were encountered:
I guess you mean submodule?
Careful with the wording here 😅
In any case, I'd strongly argue for a submodule instead of git-subtree or subrepoand make sure that the path of ImGUI is configurable.
So don't take IMGUI_DIR away, but provide a default for a (may or may not) cloned submodule.
This way, folks who want to manually manage ImGUI can do so; For other folks, the submodule should be enough and works out of the box.
eliasdaler
changed the title
Make ImGui a subrepo of ImGui-SFML
Make ImGui a git submodule of ImGui-SFML
Jan 12, 2023
I think it'll be good to pin specific ImGui commit (I'll use release ones in "master" and releases) and allow to not specify IMGUI_DIR, but get ImGui from subrepository and be sure that the version you'll be using was tested with ImGui-SFML.
The text was updated successfully, but these errors were encountered: