Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'no socket connections' with socket.io v1.3.2 #437

Closed
adam-beck opened this issue Jan 21, 2015 · 10 comments
Closed

'no socket connections' with socket.io v1.3.2 #437

adam-beck opened this issue Jan 21, 2015 · 10 comments

Comments

@adam-beck
Copy link

When running the demo application I receive a no socket connections error in the browser. The package.json lists sockets.io as "^1.2.1 which when the packages are installed socket.io version is bumped to 1.3.2. If I explicity set the demo to use sockets.io v1.2.1 I do not receive this error.

@jpbackman
Copy link
Contributor

@adam-beck which version of sc5-styleguide are you using? We released 0.3.2 today, which addresses the socket connection issue (port is ignored). The root cause is in [email protected]: socketio/socket.io-client#802

@adam-beck
Copy link
Author

I was using a previous version.

@jpbackman
Copy link
Contributor

The solution introduced in 0.3.2 is not perfect, as it assumes that users are connecting directly to the designated Express server port. Problems start when ports are forwarded.

@andreipopovici
Copy link

+1
Also having issues with forwarded ports.

@jpbackman
Copy link
Contributor

@andreipopovici we released 0.3.3 yesterday with a downgraded version of socket-io (1.2.1) which resolves socket endpoint port correctly. 0.3.4 is the latest sc5-styleguide version (minor cli argument bug fixed), please update.

@andreipopovici
Copy link

Trying it as we speak :) Will update with progress.

@jpbackman
Copy link
Contributor

0.3.4 works, we're running our demo site inside a Docker container, which forwards the internal port 3000 to something random like 49317 on the host machine, which again is mapped to 80 in nginx or apache.

http://demo.styleguide.sc5.io/

@andreipopovici
Copy link

Socket.io seems to work fine after the update. Thanks!

Heads-up: a small typo in the Gulp instructions (the comma after this line):

var sass = require('gulp-sass'),

@jpbackman
Copy link
Contributor

@andreipopovici no problem, and thanks, well spotted. Fixed it already, though. :)

@andreipopovici
Copy link

You need to slow down before these Internet wires catch fire :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants