Merge pull request #267 from hannu/function-parameter-variables

Find used variables also from function parameters

Author: Juuso Backman

lib/modules/variable-parser.js

@@ -76,6 +76,7 @@ module.exports.findVariables = function(string, syntax) {
         syntax: syntax
       });
 
+  // Find variables that are used in the styles
   gonzo.traverse(ast, [{
     // Visitor for SASS and SCSS syntaxes
     test: function(name, nodes) {
@@ -102,6 +103,20 @@ module.exports.findVariables = function(string, syntax) {
     }
   }]);
 
+  // Find variables that are used as function parameters in SASS/SCSS
+  gonzo.traverse(ast, [{
+    // Visitor for SASS and SCSS syntaxes
+    test: function(name, nodes) {
+      return name === 'arguments';
+    },
+    process: function(nodes) {
+      nodes.forEach(function(element) {
+        if (element[0] === 'variable' && element[1][0] === 'ident') {
+          out.push(element[1][1]);
+        }
+      });
+    }
+  }]);
   return out;
 };
 

test/unit/modules/variable-parser.test.js

@@ -36,6 +36,18 @@ describe('Parser', function() {
         result = ['mycolor2'];
         expect(parser.findVariables(str)).eql(result);
       });
+
+      it('should find variables that are used as function arguments', function() {
+        var str = multiline(function() {
+          /*
+          .testStyle {
+            color: rgba($mycolor, $myopacity);
+          }
+          */
+        }),
+        result = ['mycolor', 'myopacity'];
+        expect(parser.findVariables(str)).eql(result);
+      });
     });
 
     describe('LESS syntax', function() {
@@ -67,6 +79,18 @@ describe('Parser', function() {
         result = ['mycolor2'];
         expect(parser.findVariables(str, 'less')).eql(result);
       });
+
+      it('should find variables that are used as function arguments', function() {
+        var str = multiline(function() {
+          /*
+          .testStyle {
+            color: rgba(@mycolor, @myopacity);
+          }
+          */
+        }),
+        result = ['mycolor', 'myopacity'];
+        expect(parser.findVariables(str, 'less')).eql(result);
+      });
     });
   });