fix(compat/ui5-table): fire loadMore with arrow-down on last row #11401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnaydenow
approved these changes
May 7, 2025
Collaborator
|
🎉 This PR is included in version v2.10.0 🎉 The release is available on v2.10.0 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
On some screen sizes and table row's heights, the user can't reach the bottom of the table by using the arrow-down key.
Although the last row is being reached and gets focused, the very bottom of the table can't be reached, and the load-more event isn't fired.
Solution
For this use-case, but not only, we now fire the "load-more" event whenever the user presses ARROW DOWN on the last table row.
Fixes: #9235