Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[localization: legacyDateCalendarCustomizing] Islamic calendar date mapping no longer works #9980

Open
1 task done
amdev138 opened this issue Oct 4, 2024 · 0 comments
Open
1 task done
Labels
bug This issue is a bug in the code

Comments

@amdev138
Copy link

amdev138 commented Oct 4, 2024

Bug Description

Hi team,

OpenUI5 has changed the dateMapping getter's name from getLegacyDateCalendarCustomizing to getCustomIslamicCalendarData via, openui5/commit/ac04fe2e2502. So when the formatter tries to find the mapping via ,Islamic.js#L215, the mapping is undefined since the FormatSettings.ts#L28 only has the old getter.

Note: Issue exists in main, however, current ui5-wc version we are using in production is 1.24.7 and the issue exists here too (which are the versioned links listed above)

Thanks,
Allen

Affected Component

Date Picker/Calendar Components/DateFormat

Expected Behaviour

The Islamic date mapping in the configuration should be honored.

Isolated Example

https://stackblitz.com/edit/js-hwh96q?file=index.html

Steps to Reproduce

  1. The ask is pretty straight forward here and I would bet a unit test would detect this. But you can also go to stackblitz which has the init script with the mapping included.
  2. Open the date picker.
  3. See Rabi 1446. Thursday the 8th.
  4. image
  5. The expectation is it would be Thursday the 9th.
  6. image
  7. You can set a breakpoint on line 215 in Islamic.js and see that the date mapping is undefined.
    ...

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

main

Browser

Chrome, Edge, Firefox, Safari

Operating System

All

Additional Context

No response

Organization

SF

Declaration

  • I’m not disclosing any internal or sensitive information.
@amdev138 amdev138 added the bug This issue is a bug in the code label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code
Projects
None yet
Development

No branches or pull requests

1 participant