Skip to content

Commit 94bcd99

Browse files
committed
[FIX] Taskrunner: pass new taskutil options to determineRequiredDependencies hook
1 parent 7ee6dde commit 94bcd99

File tree

2 files changed

+15
-7
lines changed

2 files changed

+15
-7
lines changed

lib/build/TaskRunner.js

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -302,13 +302,15 @@ class TaskRunner {
302302
taskUtilInterface.getProject.bind(taskUtilInterface);
303303
dependencyDeterminationParams.getDependencies =
304304
taskUtilInterface.getDependencies.bind(taskUtilInterface);
305-
dependencyDeterminationParams.options = {
306-
projectName: project.getName(),
307-
projectNamespace: project.getNamespace(),
308-
configuration: taskDef.configuration,
309-
taskName: newTaskName
310-
};
311305
}
306+
307+
dependencyDeterminationParams.options = {
308+
projectName: project.getName(),
309+
projectNamespace: project.getNamespace(),
310+
configuration: taskDef.configuration,
311+
taskName: newTaskName
312+
};
313+
312314
requiredDependencies = await requiredDependenciesCallback(dependencyDeterminationParams);
313315
if (!(requiredDependencies instanceof Set)) {
314316
throw new Error(

test/lib/build/TaskRunner.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -776,7 +776,13 @@ test("Custom task with legacy spec version and requiredDependenciesCallback", as
776776

777777
t.is(requiredDependenciesCallbackStub.callCount, 1, "requiredDependenciesCallback got called once");
778778
t.deepEqual(requiredDependenciesCallbackStub.getCall(0).args[0], {
779-
availableDependencies: new Set(["dep.a", "dep.b"])
779+
availableDependencies: new Set(["dep.a", "dep.b"]),
780+
options: {
781+
projectName: "project.b",
782+
projectNamespace: "project/b",
783+
configuration: "configuration",
784+
taskName: "myTask"
785+
}
780786
}, "requiredDependenciesCallback got called with expected arguments");
781787

782788
const createDependencyReaderStub = sinon.stub(taskRunner, "_createDependenciesReader").resolves("dependencies");

0 commit comments

Comments
 (0)