-
Notifications
You must be signed in to change notification settings - Fork 7
feat: Add html linter output #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
50f344f
to
14cccc2
Compare
You may need to help me with the tests, locally they are fine. |
Thanks a lot for your contribution @marianfoo. We will take a closer look to your implementation. Updates will follow here :-) |
That's an amazing contribution @marianfoo! We will take care of this PR in backlog item CPOUI5FOUNDATION-1061. |
9c00d8d
to
e91fc35
Compare
made a rebase and updated the quiet option for the html output too
updated the test and snapshots, tests work now |
@@ -21,6 +21,7 @@ | |||
- [`--details`](#--details) | |||
- [`--format`](#--format) | |||
- [`--fix`](#--fix) | |||
- [Dry Run Mode](#dry-run-mode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why dry run mode here? I guess this is not related to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not, I have a plugin which inserts this automatically, I'll remove it
This feature add the html output.
You are welcome to finish the PR again with a colleague of yours.
example output with details from

com.ui5.troublesome.app
project:HTML Code:
Thank you for your contribution! 🙌
To get it merged faster, kindly review the checklist below:
Pull Request Checklist