Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom labels handling to instance and binding #453

Closed
kaedwen opened this issue Jul 11, 2024 · 5 comments · May be fixed by #454
Closed

Add custom labels handling to instance and binding #453

kaedwen opened this issue Jul 11, 2024 · 5 comments · May be fixed by #454

Comments

@kaedwen
Copy link

kaedwen commented Jul 11, 2024

Hey,

we are using the btp-service-operator in our environment and we need to create hana-shared aka. hana tenants. During this to also be consumable via CAP there must be a label for tenant_id and service_plan_id because CAP searches for it.

To be able to provide that from a kubernetes environment the solution would be to allow adding custom labels to the CRD's.
@kaedwen kaedwen mentioned this issue Jul 11, 2024
Open
4 tasks
@kerenlahav
Copy link
Contributor

kerenlahav commented Jul 14, 2024 •
edited
Loading

Hi @kaedwen
Do you mean Service-Manager labels or kubernetes labels?
The PR you created is adding BTP labels, how does CAP uses it?
Thanks

@kaedwen
Copy link
Author

kaedwen commented Jul 23, 2024

if CAP is used by its own, it is using service-manager credentials and the service-manager api to created the instances/bindings. These bindings do have _tenant_id and the other to identify the tenant later to provide the right credentials. But we do not want to use exclusively CAP, we also want to connect from golang microservices we create and therefore it would be the better way to create the instances/bindings via the btp-service-operator. But to not disrupt the CAP access we need to set the BTP labels there.

@kerenlahav
Copy link
Contributor

This will not work since the instances created by CAP are created in a dedicated container that belongs to CAP.
CAP will not be able to fetch instances outside of this container even if they have the label.

@kaedwen
Copy link
Author

kaedwen commented Jul 28, 2024

In our setup the provisioning of tenants is done with golang in our k8s cluster. There we create the HanaTenant ServiceInstance. We have already verified that the tenantId label is sufficient for CAP being satisfied that this HanaTenant is there (using the same Service Manager as the operator in our cluster). We do not use CAP to do the provisioning. So for us it would be great to use the sap-btp-service-operator for creating the Instance. Currently we use the sm api directly where we are able to inject the needed BTP Label.

@kerenlahav
Copy link
Contributor

We need to take it with the PO, please ping me in teams and i'll send you the feature request link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add customLabels to ServiceInstance and ServiceBinding kaedwen/sap-btp-service-operator
2 participants
@kaedwen @kerenlahav