Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Managed by Label #443

Closed
ralikio opened this issue Jun 4, 2024 · 1 comment · Fixed by #445
Closed

Missing Managed by Label #443

ralikio opened this issue Jun 4, 2024 · 1 comment · Fixed by #445

Comments

@ralikio
Copy link

ralikio commented Jun 4, 2024

services.cloud.sap.com/managed-by-sap-btp-operator label is not applied to service instances and service bindings. Because of that the limited cache functionality introduced in #435 is not going to cache service instances and service bindings.
@kerenlahav kerenlahav linked a pull request Jun 4, 2024 that will close this issue
add instances and binding to limited cache #441
Closed
@kerenlahav
Copy link
Contributor

Label is not needed, all btp operator service instances and binding will be added to the cache

@kerenlahav kerenlahav removed a link to a pull request Jun 6, 2024
add instances and binding to limited cache #441
Closed
@kerenlahav kerenlahav linked a pull request Jun 6, 2024 that will close this issue
Limited Cache - include instances and bindings to limited cache #445
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Limited Cache - include instances and bindings to limited cache SAP/sap-btp-service-operator
2 participants
@kerenlahav @ralikio