New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documentation improvements #4335

Open

1 of 3 tasks

droshev opened this issue Mar 13, 2023 · 1 comment

Labels

Contributor

droshev commented Mar 13, 2023 •

edited

Loading

Few improvements:

when we go to https://sap.github.io/fundamental-styles/ we don't get redirect to https://sap.github.io/fundamental-styles/?path=/docs/introduction--styles
missing how and what when developers need to import css files related to specific components
popover aria-hidden is not documented as a selector for hiding the popover content

The text was updated successfully, but these errors were encountered:

droshev added the documentation label

IObert commented Mar 13, 2023

It would be nice to have "setup instructions" for npm-based development on this page too. Right now, it only mentions how to embed the content from CDN in the index file. And it says "The compiled CSS for the full library and modules, e.g., core, layout, etc., are distributed via NPM."
But it doesn't mention how to use the package itself.

import "@sap-theming/theming-base-content/content/Base/baseLib/sap_fiori_3/css_variables.css"
import "fundamental-styles/dist/theming/sap_fiori_3.css"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment