Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sourcing-2][Accessibility: ACC-264.1][WIP] Table: Row details not associated to header #11266

Closed
JyotiKumari1507 opened this issue Jan 21, 2024 · 20 comments
Labels
accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support

Comments

@JyotiKumari1507
Copy link

Is this a bug, enhancement, or feature request?

Bug

Describe your proposal.

Component having issue: https://sap.github.io/fundamental-ngx/#/platform/table/basic
When the user access a single row of the table , it is observed that the row values are not associated to its header and only the cell values are mentioned. The row values of the table should always be associated to header to get the complete information.

Can you handle that on the application side

No

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

All latest version

If this is a bug, please provide steps for reproducing it; the exact components you are using;

Using Screen reader can check by implementing similar case. Just use table and access a single row of the table , it will be observe that the row values are not associated to its header and only the cell values are mentioned by screen reader

Please provide relevant source code (if applicable).

Please provide stackblitz example(s).

In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.

Yes we have got this bug from Accessibility expert only.

Did you check the documentation and the API?

Yes

Did you search for similar issues?

Is there anything else we should know?

@droshev droshev added the accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support label Jan 31, 2024
@droshev droshev changed the title [Accessibility: ACC-264.1] Table: Row details not associated to header [Sourcing-2][Accessibility: ACC-264.1] Table: Row details not associated to header Jan 31, 2024
@nikolay-kolarov
Copy link

Hi @JyotiKumari1507,

When I tried to read the table, I get announcement for the row count.
What exactly do you mean with row details? Could you please give more info?

Thanks,
Nikolay

@droshev droshev changed the title [Sourcing-2][Accessibility: ACC-264.1] Table: Row details not associated to header [Sourcing-2][Accessibility: ACC-264.1][WIP] Table: Row details not associated to header Feb 3, 2024
@JyotiKumari1507
Copy link
Author

@droshev Please refer attached screen shot of screen reader. Its reading table cell value after table name. it is observed that the row values are not associated to its header. As per accessibility team row values of the table should always be associated to header to get the complete information

image

@nikolay-kolarov
Copy link

nikolay-kolarov commented Feb 8, 2024

Hi @JyotiKumari1507,

It is strange when you give another example now. Could you please use the initial sample (https://sap.github.io/fundamental-ngx/#/platform/table/basic) and give concrete steps how to navigate in the table and what you expect?

Thanks,
Nikolay

@JyotiKumari1507
Copy link
Author

JyotiKumari1507 commented Feb 12, 2024

@nikolay-kolarov @droshev As per accessibility team, it is observed that the row values of tables are not associated to its header during screen reader readout. and this is issue. You can see in attached screenshot also table header isn't readout. its directly reading row value. If required i can ask recording from accessibility team

@nikolay-kolarov
Copy link

Hello @JyotiKumari1507,

It is hard to work over pictures or recordings.
We need info about the exactly used components (a live sample) and steps how to reproduce.

On the picture that you sent:

  • I do not understand if this is a table or list.
  • I do not understand how the user navigated to get this output.
  • I do not understand if the "Name" cell is focusable and has been focused during the navigation.
  • In the screen reader announcement I see more information that I see on the visible UI, so I cannot understand by the picture why this is the case.

If I test the link that you gave (https://sap.github.io/fundamental-ngx/#/platform/table/basic) I am able to read the column header and they are announced when navigated between columns.

Best Regards,
Nikolay

@JyotiKumari1507
Copy link
Author

@nikolay-kolarov its component https://sap.github.io/fundamental-ngx/#/platform/table/basic) only.
You can see accessibility team screen reader report in the screenshot which i attached earlier. Screen reader able to read table each sell value , but not header.
html used code:

<fdp-table
#table
id="appTable"
[dataSource]="source"
[noVerticalBorders]="true"
[noBorderX]="true"
[noBorderY]="true"
[rowsActivable]="true"
[rowNavigatable]="true"
emptyTableMessage="No Applications found"
(rowActivate)="onRowActivate($event)"
emptyTableMessage="No Applications found."
[initialSortBy]="[
{ field: 'updateAtLabel', direction: sortDirectionEnum.DESC }
]"
bodyHeight="{{
source.dataProvider.totalItems >= 16 && isCustomerTab
? '740px'
: source.dataProvider.totalItems >= 10 && !isCustomerTab
? '484px'
: 'auto'
}}"
fd-scrollbar
noHorizontalScroll

<fdp-table-toolbar
title="Applications"
[shouldOverflow]="true"

<fdp-column
name="appName"
key="appName"
label="{{ nameLabel }}"
[sortable]="true"
[filterable]="true"

<fdp-table-cell *fdpCellDef="let item">
  <div class="blue-bold">
    {{ item.appName }}
  </div>

  <div>
    {{ item.appId }}
  </div>
</fdp-table-cell>
{{ item.createdAtLabel }}

<fdp-column
name="updateAt"
key="updateAtLabel"
label="{{ changedOnLabel }}"
[sortable]="true"
[groupable]="true"
[filterable]="true"
align="end"

<fdp-table-cell *fdpCellDef="let item; as: source">
  {{ item.updateAtLabel }}
</fdp-table-cell>

<fdp-table-view-settings-dialog [table]="table" [allowDisablingSorting]="false">
<fdp-table-view-settings-filter
column="appName"
[type]="filterTypeEnum.MULTI"
label="{{ nameLabel }}"
[values]="appNameFilteringValues"

<fdp-table-view-settings-filter
column="serviceName"
[type]="filterTypeEnum.MULTI"
label="{{ serviceLabel }}"
[values]="serviceNameFilteringValues"

<fdp-table-view-settings-filter
column="createdBy"
[type]="filterTypeEnum.SINGLE"
label="{{ addedByLabel }}"
[values]="createByFilteringValues"

<fdp-table-view-settings-filter
column="createdAt"
[type]="filterTypeEnum.SINGLE"
label="{{ addedOnLabel }}"
[values]="createAtFilteringValues"

@droshev
Copy link
Contributor

droshev commented Feb 29, 2024

Most of the fields are not filled.

@JyotiKumari1507
Copy link
Author

@droshev can you pls let me know what input field expecting from us?

@droshev
Copy link
Contributor

droshev commented May 22, 2024

@JyotiKumari1507 Can you create a stackblitz example, document steps and document what your expectation is?

@droshev
Copy link
Contributor

droshev commented Jun 11, 2024

@JyotiKumari1507 Can you create a stackblitz example, steps to reproduce and what the expectation is? Otherwise we will close the ticket.

@divyamalhotra488
Copy link

Hi @droshev, you can try with the example here

@droshev
Copy link
Contributor

droshev commented Aug 2, 2024

@divyamalhotra488 can you also answer the other part of my previous post! thank you

@divyamalhotra488
Copy link

Hi @droshev, open the app with screen reader and try to read the table values.
It is observed that the row values are not associated to its header. As per accessibility team row values of the table should always be associated to header to get the complete information

Please refer

image

@droshev
Copy link
Contributor

droshev commented Aug 5, 2024

@divyamalhotra488 can you documents steps to reproduce and what the expectation is based on the stackblitz example you have provided?

@divyamalhotra488
Copy link

@droshev, open the stackblitz example and try to read the table rows using screen reader.
Expectation:
Table cell values should be announced as part of associated column header.

@droshev
Copy link
Contributor

droshev commented Aug 6, 2024

@divyamalhotra488 I followed the steps, opened stackblitz and use the keyboard navigation over the table and you can reach and read any cell:
Screenshot 2024-08-06 at 09 58 25

@nikolay-kolarov Do you think something else is needed?

@nikolay-kolarov
Copy link

Hi @droshev,
Hi @divyamalhotra488,

I also checked it and in my understanding this is working fine and the column headers are announced correctly when you enter or change a column.

recording.mp4

So I see not issue.

Best Regards,
Nikolay

@droshev droshev closed this as completed Aug 9, 2024
@MeghanaVernekar
Copy link

Hello Colleagues,

Retested the issue and issue still exists. Video evidence attached.

EMC-defect.video.Evidence-1.mp4

Regards,
Meghana.

@nikolay-kolarov
Copy link

Hello @MeghanaVernekar,

The video that you provide is for a different example and table?
Please provide a respective example, as the last provided stackblitz is different and as you can see on my video, the problem is not reproducible.

@droshev - FYI

Thanks,
Nikolay

@divyamalhotra488
Copy link

Created new issue: #12493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support
Projects
None yet
Development

No branches or pull requests

5 participants