-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🐛 [IOSSDKBUG-447]SortFilterItem Reset button func #892
Conversation
SortFilterItem.PickerItem Reset button functionality
SortFilterItem.PickerItem Reset button functionality
Spacer() | ||
self.resetAction.accessibilityIdentifier("Reset") | ||
} | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about long title if you put title and others in one ZStack
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't find a good solution for now. Try later.
Sources/FioriSwiftUICore/Views/SortFilter/FilterFeedbackBarItem+View.swift
Show resolved
Hide resolved
Sources/FioriSwiftUICore/Views/SortFilter/FilterFeedbackBarItem+View.swift
Outdated
Show resolved
Hide resolved
@@ -346,6 +346,37 @@ extension SortFilterItem { | |||
} | |||
} | |||
|
|||
/// FilterFeedbackBar ResetButton Configuration | |||
public struct FilterFeedbackBarResetButtonConfiguration: Equatable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name confusion, you can try FilterFeedbackRightBarButtonConfiguration
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xiaoyu0722 I think we should not use the wording "right" or "left" in the API names, since it will be confusing in the "right to left" language. It looks ok to me for the current name, but pls double check with Jiajun if that is actually what he wants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's a reset
button, but it will also work for clear all, that's what makes me confused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still use FilterFeedbackBarResetButtonConfiguration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the test case for "List Multiple", click "Select All", then click it again, all selected values are cleared. I would expect the second click will not trigger any clear action.
Fixed. |
SortFilterItem.PickerItem Reset button functionality.