fix: 🐛 [IOSSDKBUG-447]SortFilterItem Reset button func #892
Conversation
SortFilterItem.PickerItem Reset button functionality
SortFilterItem.PickerItem Reset button functionality
restaurantt
requested review from
billzhou0223
and removed request for
a team
| Spacer() | ||
| self.resetAction.accessibilityIdentifier("Reset") | ||
| } | ||
| }) |
There was a problem hiding this comment.
What about long title if you put title and others in one ZStack?
There was a problem hiding this comment.
Haven't find a good solution for now. Try later.
Sources/FioriSwiftUICore/Views/SortFilter/FilterFeedbackBarItem+View.swift
Show resolved
Hide resolved
Sources/FioriSwiftUICore/Views/SortFilter/FilterFeedbackBarItem+View.swift
Outdated
Show resolved
Hide resolved
| @@ -346,6 +346,37 @@ extension SortFilterItem { | |||
| } | |||
| } | |||
|
|
|||
| /// FilterFeedbackBar ResetButton Configuration | |||
| public struct FilterFeedbackBarResetButtonConfiguration: Equatable { | |||
There was a problem hiding this comment.
Name confusion, you can try FilterFeedbackRightBarButtonConfiguration.
There was a problem hiding this comment.
@xiaoyu0722 I think we should not use the wording "right" or "left" in the API names, since it will be confusing in the "right to left" language. It looks ok to me for the current name, but pls double check with Jiajun if that is actually what he wants
There was a problem hiding this comment.
If it's a reset button, but it will also work for clear all, that's what makes me confused.
There was a problem hiding this comment.
Still use FilterFeedbackBarResetButtonConfiguration.
Fixed. |
SortFilterItem.PickerItem Reset button functionality.