Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Fix scroll issue on SideBar #751

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Conversation

JunSong-SH
Copy link
Contributor

This PR addresses the issue concerning the scrolling in the UIKit Sidebar, a problem discovered while implementing UX designer enhancements.

The issue was with the Sidebar as the content of primary view in the UISplitViewController. When setting a .background modifier on a ScrollView or outside of it within the SwiftUI Sidebar, the primary view in the UISplitViewController could not be scrolled vertically and only the 'SideBar' control was scrolled vertically. After testing, I found that moving the .background modifier inside the ScrollView resolves the problem for the UIKit Sidebar.

@JunSong-SH JunSong-SH requested a review from a team as a code owner July 24, 2024 09:23
@JunSong-SH JunSong-SH requested review from billzhou0223 and removed request for a team July 24, 2024 09:23
@zzchao-1999 zzchao-1999 merged commit 217a91a into SAP:main Jul 26, 2024
11 checks passed
@JunSong-SH JunSong-SH deleted the main-fix branch July 26, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants