fix: 🐛 Fix scroll issue on SideBar #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue concerning the scrolling in the UIKit Sidebar, a problem discovered while implementing UX designer enhancements.
The issue was with the Sidebar as the content of primary view in the UISplitViewController. When setting a
.backgroundmodifier on aScrollViewor outside of it within the SwiftUI Sidebar, the primary view in the UISplitViewController could not be scrolled vertically and only the 'SideBar' control was scrolled vertically. After testing, I found that moving the.backgroundmodifier inside theScrollViewresolves the problem for the UIKit Sidebar.