Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🐛 [IOSSDKBUG-187] Fiori SDK icons have different height than in Figma #703

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

restaurantt
Copy link
Collaborator

added:
fiori.half.star (All, Actions)
fiori.da (All, Objects)
fiori.da.fill (All, Objects)
fiori.ai (All, Actions)

replaced:
fiori.pdf.attachment (All, Documents)
fiori.pdf.reader (All, Actions, Documents)

@restaurantt restaurantt requested a review from a team as a code owner June 12, 2024 08:27
@restaurantt restaurantt requested review from billzhou0223 and removed request for a team June 12, 2024 08:27
Copy link

cla-assistant bot commented Jun 12, 2024

CLA assistant check
All committers have signed the CLA.

@dyongxu dyongxu changed the title fix: 🐛 [IOSSDKBUG-187] Fiori SDK icons have different height than in Figma. feat: 🐛 [IOSSDKBUG-187] Fiori SDK icons have different height than in Figma. Jun 12, 2024
@dyongxu dyongxu changed the title feat: 🐛 [IOSSDKBUG-187] Fiori SDK icons have different height than in Figma. feat: 🐛 [IOSSDKBUG-187] Fiori SDK icons have different height than in Figma Jun 13, 2024
@dyongxu
Copy link
Contributor

dyongxu commented Jun 13, 2024

@restaurantt There is a build failure. I think it is because your commit message has a "." at the end. Pls update commit message and see if it passes the build.

@dyongxu dyongxu merged commit fda2d4a into SAP:main Jun 14, 2024
11 checks passed
@restaurantt restaurantt deleted the main-IOSSDKBUG-187 branch November 21, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants