-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🐛 map fonts with unsupported weight and trait combo to existing 72 fonts. #536
Conversation
@billzhou0223 the answer to your question" why we have to CI/build jobs" is that in I see the following build errors
|
Either we change swift-tools-version to 5.7 or you have to fix those erros //font = font.width(.condensed)
font = font.width(Font.Width.condensed) |
I am talking about these two jobs. Looks like the error still persists. |
Ignore the "pull_request_target" as this may take a different base commit and I wanted to remove that job anyway (originally I introduced it to allow code uploads to Sonar for pull requests coming from forks) It is strange that the issue still persists for CI / build "pull_request". I see it uses your latest changes But it complains about |
Issue reproducible when using Xcode 14.0 locally on my machine. Build works fine in CI when using Xcode 14.2 (https://github.com/TeamEidinger/cloud-sdk-ios-fiori-1/actions/runs/4494999119/jobs/7908154011) I assume the function was introduced later (16.1?) |
Yeah it works for xcode 14.2. I tried to guard the code with both iOS 16.1 and 16.2 but neither worked. |
Probably the best we can do is #if swift(>=5.7.1)
if #available(iOS 16.0, *) {
font = font.width(Font.Width.condensed)
}
#endif https://forums.swift.org/t/using-apis-introduced-in-ios-minor-releases/63897/1 |
Alternatively, we can define |
I will take this approach. The impact should be minimal. |
…72 fonts. (SAP#536) * fix: 🐛 map unsupported weight and trait combo to existing fonts * chore: 🤖 Fix a minor compilation issue * chore: 🤖 fix a compilation issue * chore: 🤖 fix a compilation issue * chore: 🤖 fix a compilation issue
…72 fonts. (#536) * fix: 🐛 map unsupported weight and trait combo to existing fonts * chore: 🤖 Fix a minor compilation issue * chore: 🤖 fix a compilation issue * chore: 🤖 fix a compilation issue * chore: 🤖 fix a compilation issue
No description provided.