feat: integration cards: support list with numeric header #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://ui5.sap.com/test-resources/sap/ui/integration/demokit/cardExplorer/webapp/index.html#/explore/list/numeric also fixes numeric header to consider state in addition to trend to determine color
|
PR is ready for review and merge Please note why failing checks can be ignored for now:
I'll record new snapshot reference images once this PR is merged (as I can do this via CI capabilities) |
ShawnMa16
suggested changes
Nov 25, 2020
|
|
||
| func body() -> AnyView { | ||
| AnyView( | ||
| Text(self.value ?? "") |
There was a problem hiding this comment.
Probably we can use the SafeText here I guess?
There was a problem hiding this comment.
For some reason, it cannot find SafeText. Does it work for you?
There was a problem hiding this comment.
I just tried, it won't show up either in my Xcode
There was a problem hiding this comment.
I pushed a commit which allows the use of SafeText without an instance of View and then I use it in this example
ShawnMa16
suggested changes
Nov 25, 2020
|
|
||
| func body() -> AnyView { | ||
| AnyView( | ||
| Text(self.value ?? "") |
There was a problem hiding this comment.
I just tried, it won't show up either in my Xcode
ShawnMa16
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ui5.sap.com/test-resources/sap/ui/integration/demokit/cardExplorer/webapp/index.html#/explore/list/numeric
also fixes numeric header to consider state in addition
to trend to determine color