-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integration cards: support list with numeric header #180
Conversation
https://ui5.sap.com/test-resources/sap/ui/integration/demokit/cardExplorer/webapp/index.html#/explore/list/numeric also fixes numeric header to consider state in addition to trend to determine color
PR is ready for review and merge Please note why failing checks can be ignored for now:
I'll record new snapshot reference images once this PR is merged (as I can do this via CI capabilities) |
|
||
func body() -> AnyView { | ||
AnyView( | ||
Text(self.value ?? "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we can use the SafeText
here I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, it cannot find SafeText
. Does it work for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried, it won't show up either in my Xcode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a commit which allows the use of SafeText
without an instance of View and then I use it in this example
|
||
func body() -> AnyView { | ||
AnyView( | ||
Text(self.value ?? "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried, it won't show up either in my Xcode
https://ui5.sap.com/test-resources/sap/ui/integration/demokit/cardExplorer/webapp/index.html#/explore/list/numeric
also fixes numeric header to consider state in addition
to trend to determine color