Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integration cards: support list with numeric header #180

Merged
merged 2 commits into from
Nov 25, 2020

Conversation

MarcoEidinger
Copy link
Member

https://ui5.sap.com/test-resources/sap/ui/integration/demokit/cardExplorer/webapp/index.html#/explore/list/numeric

also fixes numeric header to consider state in addition
to trend to determine color

listnumeric

@MarcoEidinger MarcoEidinger requested a review from a team as a code owner November 25, 2020 00:08
@MarcoEidinger
Copy link
Member Author

PR is ready for review and merge

Please note why failing checks can be ignored for now:

  • code formatting check fails due to incorrect formatted FioriChart sources (not part of this PR). Sheng will fix these in a future PR
  • snapshot testing due to
    • new test and missing reference image
    • changed behavior (consider state for KPI color determination and KPI unit of measurement shall be color-coded as well)

I'll record new snapshot reference images once this PR is merged (as I can do this via CI capabilities)


func body() -> AnyView {
AnyView(
Text(self.value ?? "")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we can use the SafeText here I guess?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, it cannot find SafeText. Does it work for you?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried, it won't show up either in my Xcode

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit which allows the use of SafeText without an instance of View and then I use it in this example


func body() -> AnyView {
AnyView(
Text(self.value ?? "")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried, it won't show up either in my Xcode

@MarcoEidinger MarcoEidinger merged commit 7d7c82c into SAP:main Nov 25, 2020
@MarcoEidinger MarcoEidinger deleted the intCardDev branch November 25, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants