-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear (my) confusion: cf-nodejs-logging-support vs @sap/logging #93
Comments
It seems for CAP applications, none of these are used (looking at the dependency tree), het logging to the CF Logging service works: https://cap.cloud.sap/docs/node.js/cds-log#cds-logger |
The cf-nodejs-logging-support library targets the Application Logging service for Cloud Foundry applications. Afaik there is no good integration between CAP and this library but @KarstenSchnitter @nicklas-dohrn can probably add more beef to my statement. |
FYI In the meanwhile I have raised the question regarding the REMOTE_USER in CAP here: https://answers.sap.com/questions/13497765/3-different-packages-provided-by-sap-for-logging-i.html I don't see any added value of having It would be good to avoid confusion if It would benefit everyone if sap-cloud-sdk and @sap/cds actually used this package instead of each having their own take on implementing an integration with the Application Logging service. |
We get your issue, it is not nice from a CAP customer side. The Application Logging service documentation points to the correct libraries We cannot say much about @sap/logging yet, we try to figure out. I think the pointers should be fixed on CAP side. |
Hi @juergen-walter, this issue is open now for about 10 month. Is the clarification still ongoing or what is the result? Heve you taled to the CAP colleagues? |
There are two not 100% compatible use cases: Using CAP and Application Logging. Therefore, there are two libraries arround. https://www.npmjs.com/package/@sap/logging https://www.npmjs.com/package/cf-nodejs-logging-support The libraries cannot be compatible as long as the services are not compatible. |
Hello @juergen-walter, as far as I can see from sap/[email protected]/package.json CAP has no dependency to @sap/logging. Based on the documentation CAP Service SDK for Node.js -> Minimalistic Logging Facade the logging functionality is provided by CAP itself. With Kibana-Friendly Formatter it seems also to provide the needed data for the SAP Application Logging -> Fields. Maybe @danjoa can add his insights here. Best Regards |
What is the actual difference between these packages and the proper use-case for each?
I have used @sap/logging and actually ended up in this repo per accident looking for specific documentation on logging REMOTE_USER.
The text was updated successfully, but these errors were encountered: