Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Cannot find module 'fs/promises' in Node 12.x #57

Closed
jung-thomas opened this issue Jul 1, 2021 · 17 comments
Closed

Error: Cannot find module 'fs/promises' in Node 12.x #57

jung-thomas opened this issue Jul 1, 2021 · 17 comments
Assignees

Comments

@jung-thomas
Copy link
Contributor

Tool crashes with Error: Cannot find module 'fs/promises' when used in Node 12.x. This is due to this feature being introduced in Node 10 but then removed in later patches for Node 10 and Node 12. Works fine in Node 14. Node.js documentation was incorrectly listing this as supported in Node 12. See nodejs/node#35740

Will fix in hana-cli by changing to require('fs').promises

@jung-thomas jung-thomas self-assigned this Jul 1, 2021
jung-thomas added a commit that referenced this issue Jul 1, 2021
ThePlenkov added a commit to ThePlenkov/hana-developer-cli-tool-example that referenced this issue Jul 6, 2021
* no user-defined types (#9)

* Version 2.202105.9

* Integrate mass rename proposal

* Fixes for rename without namespace

* Update README.md

* Update README.md

* Update README.md

* Remove AFL Lang from hdiconfig on HANA Cloud

* Fix connect issue in clean system

* Fix Issue SAP-samples#56

* Fix Issue SAP-samples#57

Co-authored-by: Thomas Jung <[email protected]>
@AR-Student824
Copy link

F

@ericscottmarquez
Copy link

f

1 similar comment
@mxchinegod
Copy link

f

@julioantonio12
Copy link

F

1 similar comment
@sleepysmile
Copy link

F

@beasteca
Copy link

beasteca commented Nov 9, 2021

f

@grasshopperL
Copy link

F

1 similar comment
@Jorgcp99
Copy link

F

@zeromero-dev
Copy link

f

@zhanilyasov
Copy link

F

@etkaar
Copy link

etkaar commented Jan 28, 2022

F

1 similar comment
@elpideus
Copy link

F

@rteobaldo
Copy link

f

@wian-lloyd
Copy link

f

@danielwust
Copy link

F

1 similar comment
@thegu5
Copy link

thegu5 commented Jan 7, 2023

F

WillRock19 added a commit to WillRock19/TikTakToe that referenced this issue Mar 25, 2023
Removed Node 12.x version because it was breaking the build (see the reason here: SAP-samples/hana-developer-cli-tool-example#57)
@AugustoPreis
Copy link

F

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests