Skip to content

Conversation

@tarcieri
Copy link
Member

@tarcieri tarcieri commented Sep 2, 2021

Sourced from git.

This includes transitive updates to ff and group v0.11. A major notable change of these updates is switching several APIs to use subtle::Choice and subtle::CtOption instead of bool/Option.

Fortunately, the crates in this repo are already written with constant-time implementations internally, so this was an easy change.

@tarcieri tarcieri force-pushed the elliptic-curve/v0.11.0-pre branch from a7c3282 to d5b17f3 Compare September 2, 2021 22:42
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021

Codecov Report

Merging #402 (bfd1e3d) into master (eda5854) will increase coverage by 0.05%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
+ Coverage   58.59%   58.65%   +0.05%     
==========================================
  Files          29       29              
  Lines        4565     4540      -25     
==========================================
- Hits         2675     2663      -12     
+ Misses       1890     1877      -13     
Impacted Files Coverage Δ
p256/src/ecdsa.rs 90.47% <ø> (ø)
k256/src/arithmetic/scalar.rs 91.93% <60.00%> (+0.29%) ⬆️
k256/src/ecdsa/recoverable.rs 58.90% <66.66%> (+1.76%) ⬆️
p256/src/arithmetic/scalar.rs 81.86% <81.81%> (+1.24%) ⬆️
k256/src/ecdsa.rs 90.90% <100.00%> (+0.90%) ⬆️
k256/src/ecdsa/normalize.rs 100.00% <100.00%> (ø)
k256/src/ecdsa/sign.rs 17.50% <100.00%> (ø)
k256/src/ecdsa/verify.rs 60.00% <100.00%> (ø)
p256/src/arithmetic/field.rs 76.83% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eda5854...bfd1e3d. Read the comment docs.

@tarcieri tarcieri force-pushed the elliptic-curve/v0.11.0-pre branch from d5b17f3 to 5422aa2 Compare September 2, 2021 22:52
Sourced from git.

This includes transitive updates to ff and group v0.11. A major notable
change of these updates is switching several APIs to use
`subtle::Choice` and `subtle::CtOption` instead of `bool`/`Option`.

Fortunately, the crates in this repo are already written with
constant-time implementations internally, so this was an easy change.
@tarcieri tarcieri force-pushed the elliptic-curve/v0.11.0-pre branch from 5422aa2 to bfd1e3d Compare September 2, 2021 23:01
@tarcieri tarcieri merged commit 616b20c into master Sep 2, 2021
@tarcieri tarcieri deleted the elliptic-curve/v0.11.0-pre branch September 2, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants