clippy fixes

Author: fjarri

src/modular/boxed_residue/add.rs

@@ -63,6 +63,7 @@ impl AddAssign<BoxedResidue> for BoxedResidue {
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used)]
 mod tests {
     use crate::{
         modular::{BoxedResidue, BoxedResidueParams},

src/modular/boxed_residue/sub.rs

@@ -64,6 +64,7 @@ impl SubAssign<BoxedResidue> for BoxedResidue {
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used)]
 mod tests {
     use crate::{
         modular::{BoxedResidue, BoxedResidueParams},

src/uint/boxed/add_mod.rs

@@ -34,6 +34,7 @@ impl AddMod for BoxedUint {
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used)]
 mod tests {
     use super::BoxedUint;
     use hex_literal::hex;

src/uint/boxed/bits.rs

@@ -64,6 +64,7 @@ impl BoxedUint {
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used)]
 mod tests {
     use super::BoxedUint;
     use hex_literal::hex;

src/uint/boxed/encoding.rs

@@ -118,6 +118,7 @@ impl BoxedUint {
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used)]
 mod tests {
     use super::{BoxedUint, DecodeError};
     use crate::Limb;

src/uint/boxed/inv_mod.rs

@@ -146,6 +146,7 @@ impl BoxedUint {
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used)]
 mod tests {
     use super::BoxedUint;
     use hex_literal::hex;

src/uint/boxed/sub_mod.rs

@@ -49,6 +49,7 @@ impl SubMod for BoxedUint {
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used)]
 mod tests {
     use super::BoxedUint;
     use hex_literal::hex;

tests/boxed_residue_proptests.rs

@@ -82,7 +82,7 @@ proptest! {
 
         let a_bi = retrieve_biguint(&a);
         let b_bi = retrieve_biguint(&b);
-        let p_bi = to_biguint(&p);
+        let p_bi = to_biguint(p);
         let expected = (a_bi * b_bi) % p_bi;
 
         prop_assert_eq!(retrieve_biguint(&actual), expected);

tests/boxed_uint_proptests.rs

@@ -46,11 +46,11 @@ prop_compose! {
 prop_compose! {
     /// Generate a pair of random `BoxedUint`s with the same precision.
     fn uint_pair()(mut a in uint(), mut b in uint()) -> (BoxedUint, BoxedUint) {
-        if a.bits_precision() > b.bits_precision() {
-            b = b.widen(a.bits_precision());
-        } else if a.bits_precision() < b.bits_precision() {
-            a = a.widen(b.bits_precision());
-        }
+        match a.bits_precision().cmp(&b.bits_precision()) {
+            Ordering::Less => a = a.widen(b.bits_precision()),
+            Ordering::Equal => {},
+            Ordering::Greater => b = b.widen(a.bits_precision()),
+        };
 
         (a, b)
     }