Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error.rs: consider dropping negatives #294

Open
ojeda opened this issue May 26, 2021 · 0 comments
Open

error.rs: consider dropping negatives #294

ojeda opened this issue May 26, 2021 · 0 comments
Labels
• lib Related to the `rust/` library.

Comments

@ojeda
Copy link
Member

ojeda commented May 26, 2021 •
edited
Loading

From @nbdd0121 #287 (comment):

We might want to drop all negatives. All C side macros define error codes as positive, and it's only used as negative values to tell part between success and failure. Rust side shouldn't use that pattern at all and should use Result exclusively anyway, so negative values are not meaningful.
@ojeda ojeda added • lib Related to the `rust/` library. prio: normal labels May 26, 2021
@ojeda ojeda changed the title rust/kernel/error.rs: Consider dropping negatives error.rs: consider dropping negatives May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
• lib Related to the `rust/` library.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ojeda