-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic SDL2 build fails on windows with bundled feature #1088
Comments
While here, also add CI testing for Windows bundled builds (both dynamic and static-link). Closes Rust-SDL2#1088.
Broke non-"static-link" builds on Windows when using "bundled" and non release builds. Closes Rust-SDL2#1088
FYI I got linking to work correctly, with CI testing, in PR #1092 What is concerning however is that while the static-link version of "bundled" passes tests 100%, the following happens on the dynamic link version:
Given that most of the tests are passing, but some are failing, something is subtly wrong with this version of the build. My first guess is that there is an ABI difference that isn't getting picked up one one side of the build. |
Ah, these are the examples that actually invoke code in sdl2 thus need the runtime linking. |
Broke non-"static-link" builds on Windows when using "bundled" and non release builds. Closes #1088
Broke non-"static-link" builds on Windows when using "bundled" and non release builds. Closes Rust-SDL2#1088
The error:
My Cargo.toml:
The text was updated successfully, but these errors were encountered: