Getting PixelFormat from PixelFormatEnum?

[sarracht]

Color::to_u32() requires a &PixelFormat, but I've got a PixelFormatEnum and I can't figure out how to convert it. There's a From implementation for PixelFormat to PixelFormatEnum, but nothing the other way around as far as I can tell.

The overall project here is drawing text with rusttype. Best I've figured is to get a Color for each pixel, ram them all in a Vec<u32>, pass that data as a &[u8] to Surface::from_data(), then TextureCreator::create_texture_from_surface(). If there's a better/simpler way, I'm all ears.

[khernyo]

The following seems to work:

PixelFormat::from_ll(sdl2::sys::SDL_AllocFormat(pixel_format_enum as u32))

Swiped from https://stackoverflow.com/a/32000743/203487

[Cobrand]

Seems like there could be a helper in rust-sdl2 to help you do that without unsafe. I'm tagging it as functionality, if someone sees this and wants to make a PR, feel free!

[ishanjain28]

@Cobrand Hi, Is an Into trait implementation to go from PixelFormatEnum to PixelFormat that uses unsafe okay?

[Cobrand]

I think it's fine to use unsafe here, as long as we guarantee ourselves that the code cannot fail according to the sdl2 doc.

[mnmaita]

@Cobrand I guess this issue is closeable as per #898