Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL_VERSION macro is not exposed #694

Closed
dariost opened this issue Aug 22, 2017 · 1 comment · Fixed by #695
Closed

SDL_VERSION macro is not exposed #694

dariost opened this issue Aug 22, 2017 · 1 comment · Fixed by #695

Comments

@dariost
Copy link
Contributor

dariost commented Aug 22, 2017

https://wiki.libsdl.org/SDL_VERSION doesn't seem to be exposed. sdl2::version::version uses SDL_GetVersion (https://github.com/Rust-SDL2/rust-sdl2/blob/master/src/sdl2/version.rs#L38), which returns the linked version. SDL_VERSION returns the compiled version instead.

SDL_VERSION is crucial for functions like https://wiki.libsdl.org/SDL_GetWindowWMInfo.

@Cobrand
Copy link
Member

Cobrand commented Aug 23, 2017

Well, how would you implement that? If sdl2-sys was dynamically generated via bindgen, we would be able to get this macro right, but otherwise there is simply no way. Say SDL_VERSION becomes 2.0.6, and it has code dependant on it; what happens if that code actually uses 2.0.5?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants