Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video::gl_get_swap_interval() should return an enum #655

Closed
icefoxen opened this issue May 10, 2017 · 1 comment
Closed

Video::gl_get_swap_interval() should return an enum #655

icefoxen opened this issue May 10, 2017 · 1 comment
Milestone

Comments

@icefoxen
Copy link
Contributor

Right now it returns an i32 when the only valid values are 1, 0, and -1, all of which have specific discrete meanings.

Naturally, Video::gl_set_swap_interval() should also use this enum.

Also it'd be nice if "vsync" were mentioned in the docs near it so you could ever find it. Grrrr SDL2.

Will throw together a PR when I get a chance.

@Cobrand Cobrand added this to the 0.31 milestone Jul 10, 2017
@Cobrand
Copy link
Member

Cobrand commented Jul 25, 2017

Closed by #684

@Cobrand Cobrand closed this as completed Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants