Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_audio_cvt still broken on Windows (on stable) #1114

Open
waych opened this issue Jun 6, 2021 · 2 comments
Open

test_audio_cvt still broken on Windows (on stable) #1114

waych opened this issue Jun 6, 2021 · 2 comments

Comments

@waych
Copy link
Contributor

waych commented Jun 6, 2021

test_audio_cvt shows breakage again on CI, on "bundled" "--release" Windows builds.

When this was previously seen (as a STATUS_HEAP_CORRUPTION), it was discovered through inspection on the underlying library that it is possible for sdl2 to reallocate the buffer passed in in cases where it wants to use an intermediate buffer. This was addressed in #1098 by having the buffer passed in explicitly allocated via sdl2's heap. This seemed to make the problem go away long enough to make CI pass.

The problem seems to have cropped up however again, this time on as a STATUS_ACCESS_VIOLATION. When I last looked into this issue, I compared the disassembly of the debug and release builds and noticed that the use of SSE registers were drastically different and possibly suspect to the problem, but I left that theory when the underlying buffer reallocation theory came up.

Looking at this issue locally, I am able to reproduce, but importantly, this is only happening on rust stable (1.52.1), but it works correctly on nightly (1.54.0) and on beta (1.53-beta.3). This leads me to believe this was/is an underlying compiler issue that will pass?

@Cobrand
Copy link
Member

Cobrand commented Jun 6, 2021

That's good news that it's fixed in nightly and beta, but really worrying that this is happening on stable... Were you able to reproduce this issue locally? I was thinking we could test it with several old rust versions, to see if the issue is just specific to 1.52.1 or if it has been there a while.

@waych
Copy link
Contributor Author

waych commented Jun 7, 2021

Seems to be only broken on 1.52.1. Tests pass locally just fine with either 1.51 or 1.50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants