You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
test_audio_cvt shows breakage again on CI, on "bundled" "--release" Windows builds.
When this was previously seen (as a STATUS_HEAP_CORRUPTION), it was discovered through inspection on the underlying library that it is possible for sdl2 to reallocate the buffer passed in in cases where it wants to use an intermediate buffer. This was addressed in #1098 by having the buffer passed in explicitly allocated via sdl2's heap. This seemed to make the problem go away long enough to make CI pass.
The problem seems to have cropped up however again, this time on as a STATUS_ACCESS_VIOLATION. When I last looked into this issue, I compared the disassembly of the debug and release builds and noticed that the use of SSE registers were drastically different and possibly suspect to the problem, but I left that theory when the underlying buffer reallocation theory came up.
Looking at this issue locally, I am able to reproduce, but importantly, this is only happening on rust stable (1.52.1), but it works correctly on nightly (1.54.0) and on beta (1.53-beta.3). This leads me to believe this was/is an underlying compiler issue that will pass?
The text was updated successfully, but these errors were encountered:
That's good news that it's fixed in nightly and beta, but really worrying that this is happening on stable... Were you able to reproduce this issue locally? I was thinking we could test it with several old rust versions, to see if the issue is just specific to 1.52.1 or if it has been there a while.
test_audio_cvt shows breakage again on CI, on "bundled" "--release" Windows builds.
When this was previously seen (as a STATUS_HEAP_CORRUPTION), it was discovered through inspection on the underlying library that it is possible for sdl2 to reallocate the buffer passed in in cases where it wants to use an intermediate buffer. This was addressed in #1098 by having the buffer passed in explicitly allocated via sdl2's heap. This seemed to make the problem go away long enough to make CI pass.
The problem seems to have cropped up however again, this time on as a STATUS_ACCESS_VIOLATION. When I last looked into this issue, I compared the disassembly of the debug and release builds and noticed that the use of SSE registers were drastically different and possibly suspect to the problem, but I left that theory when the underlying buffer reallocation theory came up.
Looking at this issue locally, I am able to reproduce, but importantly, this is only happening on rust stable (1.52.1), but it works correctly on nightly (1.54.0) and on beta (1.53-beta.3). This leads me to believe this was/is an underlying compiler issue that will pass?
The text was updated successfully, but these errors were encountered: