Skip to content

Commit 4becd2a

Browse files
authored
Eng 2635 Add automated periodic testing coverage for MariaDB (#1225)
Co-authored-by: Eunice Chan <[email protected]>
1 parent 6fdafa9 commit 4becd2a

File tree

2 files changed

+21
-4
lines changed

2 files changed

+21
-4
lines changed

.github/workflows/periodic-integration-tests.yml

+16
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,22 @@ jobs:
134134
ports:
135135
# Maps tcp port 5432 on service container to the host
136136
- 5432:5432
137+
138+
mariadb:
139+
image: mariadb:10.7
140+
env:
141+
MARIADB_USER: aqueduct
142+
MARIADB_PASSWORD: aqueduct
143+
MARIADB_ROOT_PASSWORD: aqueduct
144+
MARIADB_DATABASE: aqueducttest
145+
options: >-
146+
--health-cmd="mysqladmin ping"
147+
--health-interval 10s
148+
--health-timeout 5s
149+
--health-retries 5
150+
ports:
151+
# Maps tcp port 3306 on service container to 3808 on the host
152+
- 3808:3306
137153
steps:
138154
- uses: actions/checkout@v2
139155

integration_tests/sdk/setup_integration.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -219,11 +219,12 @@ def setup_data_integrations(client: Client, filter_to: Optional[str] = None) ->
219219
# Stand up the external integration first.
220220
if integration_config["type"] == ServiceType.SQLITE:
221221
_setup_external_sqlite_db(integration_config["database"])
222-
223-
if integration_config["type"] == ServiceType.POSTGRES:
222+
elif integration_config["type"] == ServiceType.POSTGRES:
224223
_setup_postgres_db()
225-
226-
if integration_config["type"] == ServiceType.MYSQL:
224+
elif (
225+
integration_config["type"] == ServiceType.MYSQL
226+
or integration_config["type"] == ServiceType.MARIADB
227+
):
227228
_setup_mysql_db()
228229

229230
client.connect_integration(

0 commit comments

Comments
 (0)