Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bash script bug and Add new Language Selection Feature #104

Merged
merged 14 commits into from
Oct 25, 2024
Merged

Fix bash script bug and Add new Language Selection Feature #104

merged 14 commits into from
Oct 25, 2024

Conversation

wickdynex
Copy link
Contributor

Overview of Changes

  1. Add new feature to install.sh: specify the language, use -l zh or -l en to select.
  2. Fix the architect selection bugs: now can identify not only aarch64 but also arm64 arch.
  3. Fix the empty directory bug: if your specified dir not exist, it will create one.
  4. Add readme.txt: describe the usage of script.

Related Issues

Fixed #98

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Code refactoring

Impact

Fix the install bugs, also add new language seleted feature, and make scripts more readable and usable.

Pretending Test

Use install.sh to install any version on any architect and os, test any couples of flags.

@wickdynex
<fix>: not support specifying version.
9a7aab6
@wickdynex
<fix>: add logic to judge whether dir exists.
fad3441
@wickdynex
<update>: add version specify feature.
2ec4957
@wickdynex
<fix>: fix bug, macOS m1 report $arch: arm64.
73b23fc
@wickdynex
<fix>: if exit with error, catch the signal, clean up the tmp dir.
9f3046b
@wickdynex
<update>: add new comments, update help func display.
3f0e7fa
@wickdynex
<add>: add readable comments on script func.
9db18d2
@wickdynex
<create>: create a English version script.
e13656e
@wickdynex
<create>: create a readme file to describe files feature.
5c1524f
@wickdynex
<add>: add new feature '-l' to select language.
2d0e198
@wickdynex
<update>: update readme Files part's description.
10ec1fc
@wickdynex
<delete>: delete en version script.
7540588
@wickdynex
<update>: if noroot user, install at "$HOME/.local/bin".
322a3c9
@wickdynex
Merge commit '6a81785a4d11575895e6030b2c59f44fb3b8e854' into update-b…
5405ce9 
…ash-script
@ccmywish ccmywish added Release Release Challenge Challenge labels Oct 25, 2024
@ccmywish ccmywish added this to the v0.2.0 milestone Oct 25, 2024
@ccmywish ccmywish changed the base branch from main to dev October 25, 2024 14:36
@ccmywish ccmywish merged commit 15c0ae6 into RubyMetric:dev Oct 25, 2024
@ccmywish
Copy link
Contributor

@1328032567

Your code is very helpful and meticulous. Thank you! 👍

ccmywish added a commit that referenced this pull request Oct 25, 2024
@ccmywish
Fix install.sh to make it runnable
c6a0801 
[GitHub #98 #104]
@wickdynex
Copy link
Contributor Author

@1328032567

Your code is very helpful and meticulous. Thank you! 👍

Thanks for your praise, I'm very grateful and delighted.
I consider to use getopt func to instead of getopts so that the script can parser long option like this --help. However, the concrete implement of getopt is not always the same on different OS, so I give up. To fix and also implement this file, I referred to the content of classical project build-scripts.
Btw, I'd also like to implement the powershell version, but I'm new in posh, so I'd also like to refer the context from other projects.

@ccmywish
Copy link
Contributor

I already added a simple PowerShell version, very simple, you can modify and improve it as you like. Go for it~

@wickdynex
Copy link
Contributor Author

I already added a simple PowerShell version, very simple, you can modify and improve it as you like. Go for it~

Gosh! U are so considerate, I'll hurry up. Thank you for your replying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Challenge Challenge Release Release
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

[Challenge] 编写统一安装的 shell 和 PowerShell 脚本
2 participants
@wickdynex @ccmywish