-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random slideshow and the ability to randomly display all resources #153
Comments
RANDOM_SLIDESHOW now plays an actually shuffled slideshow. |
Thanks a lot, but why the limitation to 1000 images? I think it should be at least 10.000. |
There should be definitely a limitation, which value do you think could be a good idea? |
If you have the time, you could raise a feature request for your chronological sorting feature. |
1000 should be more than fine, because after the default refresh interval, which is 1 hour per default, and a default slideshow interval of 30 seconds, we just need 120 images right? But this should not be hardcoded, thus it should be calculated by this formula: Related PR: #155 |
I think this approach works well, thank you. |
Discussed in #152
Originally posted by joe128 December 17, 2024
Problem
If the config
RANDOM_SLIDESHOW
is enabled, a random image is fetched for eachslideshowTick
. So there is a very high chance that an image will be displayed twice before all resources have been displayed.This behaviour isn't suitable if you want to display a slideshow over a small number of images.
(I have mentioned this issue and my usecase under #138 (comment))
Solution
Perhaps we could introduce a config that allows a kind of "shuffle and display all resources" (SHUFFLE_ALL)?
Another possibilities
RANDOM_SLIDESHOW
SHOW_ALL
(with optionalRANDOM_SLIDESHOW
)I have already implemented a POC and tested it with a small set of images.
Minimal config example to reproduce:
The text was updated successfully, but these errors were encountered: