Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of loops for autoselection of standard fields. #4076

Open
svenoe opened this issue Jan 15, 2025 · 0 comments
Open

Reduce number of loops for autoselection of standard fields. #4076

svenoe opened this issue Jan 15, 2025 · 0 comments
Labels
technical improvement Technical stuff, not user visible
Milestone

Comments

@svenoe
Copy link
Contributor

svenoe commented Jan 15, 2025

From a quick look, I believe changing elsif to if in all places like

elsif ( !$GetParam{ $Field->{FieldID} } && $Autoselect && $Autoselect->{ $Field->{FieldID} } ) {
should be more correct and save the additional loop which I assume currently is run when a selected option for a field is removed (in the block before it then is emptied) and another one thereby is autoselected.

This should affect all Kernel/Modules/ modules which have the covergence block in four places (at least), initial rendering and AJAXUpdate, both normal standard fields and the explicit QueueID section above.

@svenoe svenoe added the technical improvement Technical stuff, not user visible label Jan 15, 2025
@svenoe svenoe added this to the OTOBO 11.0.9 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical improvement Technical stuff, not user visible
Projects
None yet
Development

No branches or pull requests

1 participant