Skip to content

Commit eabaaa6

Browse files
committed
test: fix tautological assertion in API handler rebuild test
- Capture original API reference before upsertProviderProfile call - Assert against original reference instead of self-comparison - Addresses ellipsis-dev review comment
1 parent b39308c commit eabaaa6

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

src/core/webview/__tests__/ClineProvider.apiHandlerRebuild.spec.ts

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -259,12 +259,13 @@ describe("ClineProvider - API Handler Rebuild Guard", () => {
259259
openRouterModelId: "openai/gpt-4",
260260
},
261261
})
262-
mockTask.api = {
262+
const originalApi = {
263263
getModel: vi.fn().mockReturnValue({
264264
id: "openai/gpt-4",
265265
info: { contextWindow: 128000 },
266266
}),
267-
} as any
267+
}
268+
mockTask.api = originalApi as any
268269

269270
await provider.addClineToStack(mockTask)
270271

@@ -286,8 +287,8 @@ describe("ClineProvider - API Handler Rebuild Guard", () => {
286287

287288
// Verify buildApiHandler was NOT called since provider/model unchanged
288289
expect(buildApiHandlerMock).not.toHaveBeenCalled()
289-
// Verify the task's api property was NOT reassigned
290-
expect(mockTask.api).toBe(mockTask.api) // Same reference
290+
// Verify the task's api property was NOT reassigned (still same reference)
291+
expect(mockTask.api).toBe(originalApi)
291292
})
292293

293294
test("rebuilds API handler when provider changes", async () => {
@@ -393,12 +394,13 @@ describe("ClineProvider - API Handler Rebuild Guard", () => {
393394
openRouterModelId: "openai/gpt-4",
394395
},
395396
})
396-
mockTask.api = {
397+
const originalApi = {
397398
getModel: vi.fn().mockReturnValue({
398399
id: "openai/gpt-4",
399400
info: { contextWindow: 128000 },
400401
}),
401-
} as any
402+
}
403+
mockTask.api = originalApi as any
402404

403405
await provider.addClineToStack(mockTask)
404406

@@ -416,6 +418,8 @@ describe("ClineProvider - API Handler Rebuild Guard", () => {
416418

417419
// Verify buildApiHandler was NOT called
418420
expect(buildApiHandlerMock).not.toHaveBeenCalled()
421+
// Verify the API reference wasn't changed
422+
expect(mockTask.api).toBe(originalApi)
419423
})
420424

421425
test("rebuilds API handler when provider changes", async () => {

0 commit comments

Comments
 (0)