fix: prevent infinite loop when attempt_completion succeeds (#9325)

daniel-lxs · web-flow · commit e742511d90cc · 2025-11-17T18:24:48.000-05:00
diff --git a/src/core/tools/AttemptCompletionTool.ts b/src/core/tools/AttemptCompletionTool.ts
@@ -83,10 +83,10 @@ export class AttemptCompletionTool extends BaseTool<"attempt_completion"> {
 			const { response, text, images } = await task.ask("completion_result", "", false)
 
 			if (response === "yesButtonClicked") {
-				pushToolResult("")
 				return
 			}
 
+			// User provided feedback - push tool result to continue the conversation
 			await task.say("user_feedback", text ?? "", images)
 
 			const feedbackText = `The user has provided feedback on the results. Consider their input to continue the task, and then attempt completion again.\n<feedback>\n${text}\n</feedback>`

Original file line number	Diff line number	Diff line change
`@@ -83,10 +83,10 @@ export class AttemptCompletionTool extends BaseTool<"attempt_completion"> {`
`83`	`83`	`const { response, text, images } = await task.ask("completion_result", "", false)`
`84`	`84`
`85`	`85`	`if (response === "yesButtonClicked") {`
`86`		`- pushToolResult("")`
`87`	`86`	`return`
`88`	`87`	`}`
`89`	`88`
	`89`	`+ // User provided feedback - push tool result to continue the conversation`
`90`	`90`	`await task.say("user_feedback", text ?? "", images)`
`91`	`91`
`92`	`92`	const feedbackText = `The user has provided feedback on the results. Consider their input to continue the task, and then attempt completion again.\n<feedback>\n${text}\n</feedback>`