fix(webview): handle batch updateSettings (writeDelayMs, soundEnabled, ttsEnabled/ttsSpeed, autoCondenseContext/Percent, browserToolEnabled, showRooIgnoredFiles, alwaysApproveResubmit, requestDelaySeconds, maxWorkspaceFiles clamp, mcpEnabled) and post state

Author: hannesrudolph

src/core/webview/webviewMessageHandler.ts

@@ -1284,19 +1284,54 @@ export const webviewMessageHandler = async (
 			break
 		}
 		case "updateSettings":
-			if (message.updatedSettings && typeof message.updatedSettings.mcpEnabled !== "undefined") {
-				const mcpEnabledValue = Boolean(message.updatedSettings.mcpEnabled)
-				await updateGlobalState("mcpEnabled", mcpEnabledValue)
+			if (message.updatedSettings) {
+				const s = message.updatedSettings as Record<string, any>
 
-				const mcpHubInstance = provider.getMcpHub()
+				const setIfDefined = async <K extends keyof GlobalState>(key: K, value: GlobalState[K] | undefined) => {
+					if (typeof value !== "undefined") {
+						await updateGlobalState(key, value as GlobalState[K])
+					}
+				}
+
+				// Batch-update supported settings
+				await setIfDefined("writeDelayMs", s.writeDelayMs)
+				await setIfDefined("soundEnabled", s.soundEnabled)
+
+				if (typeof s.ttsEnabled !== "undefined") {
+					const v = !!s.ttsEnabled
+					await updateGlobalState("ttsEnabled", v)
+					setTtsEnabled(v)
+				}
+				if (typeof s.ttsSpeed === "number") {
+					await updateGlobalState("ttsSpeed", s.ttsSpeed)
+					setTtsSpeed(s.ttsSpeed)
+				}
+
+				await setIfDefined("autoCondenseContext", s.autoCondenseContext)
+				await setIfDefined("autoCondenseContextPercent", s.autoCondenseContextPercent)
+				await setIfDefined("browserToolEnabled", s.browserToolEnabled)
+				await setIfDefined("showRooIgnoredFiles", s.showRooIgnoredFiles)
+				await setIfDefined("alwaysApproveResubmit", s.alwaysApproveResubmit)
+				await setIfDefined("requestDelaySeconds", s.requestDelaySeconds)
 
-				if (mcpHubInstance) {
-					await mcpHubInstance.handleMcpEnabledChange(mcpEnabledValue)
+				if (typeof s.maxWorkspaceFiles === "number") {
+					const fileCount = Math.min(Math.max(0, s.maxWorkspaceFiles), 500)
+					await updateGlobalState("maxWorkspaceFiles", fileCount)
+				}
+
+				// MCP enabled/disabled
+				if (typeof s.mcpEnabled !== "undefined") {
+					const mcpEnabledValue = !!s.mcpEnabled
+					await updateGlobalState("mcpEnabled", mcpEnabledValue)
+					const mcpHubInstance = provider.getMcpHub()
+					if (mcpHubInstance) {
+						await mcpHubInstance.handleMcpEnabledChange(mcpEnabledValue)
+					}
 				}
 
 				await provider.postStateToWebview()
 			} else {
-				// No recognized settings provided; refresh state to keep UI in sync
+				// No settings provided; refresh to keep UI in sync
 				await provider.postStateToWebview()
 			}
 			break