Skip to content

Commit d64f82e

Browse files
committed
PR feedback
1 parent 1e298a5 commit d64f82e

File tree

2 files changed

+1
-31
lines changed

2 files changed

+1
-31
lines changed

webview-ui/src/components/ui/__tests__/tooltip.spec.tsx

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -80,31 +80,6 @@ describe("Tooltip", () => {
8080
{ timeout: 1000 },
8181
)
8282
})
83-
84-
it("should apply VSCode native shadow styling", async () => {
85-
const user = userEvent.setup()
86-
87-
render(
88-
<TooltipProvider delayDuration={0}>
89-
<Tooltip>
90-
<TooltipTrigger>Hover me</TooltipTrigger>
91-
<TooltipContent>Tooltip with shadow</TooltipContent>
92-
</Tooltip>
93-
</TooltipProvider>,
94-
)
95-
96-
const trigger = screen.getByText("Hover me")
97-
await user.hover(trigger)
98-
99-
await waitFor(
100-
() => {
101-
const tooltips = screen.getAllByText("Tooltip with shadow")
102-
const visibleTooltip = tooltips.find((el) => el.getAttribute("role") !== "tooltip")
103-
expect(visibleTooltip).toHaveClass("shadow-[0_2px_8px_var(--color-vscode-widget-shadow)]")
104-
},
105-
{ timeout: 1000 },
106-
)
107-
})
10883
})
10984

11085
describe("StandardTooltip", () => {

webview-ui/src/index.css

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@
131131
--color-vscode-inputValidation-infoBorder: var(--vscode-inputValidation-infoBorder);
132132

133133
--color-vscode-widget-border: var(--vscode-widget-border);
134+
--color-vscode-widget-shadow: var(--vscode-widget-shadow);
134135

135136
--color-vscode-textLink-foreground: var(--vscode-textLink-foreground);
136137

@@ -139,12 +140,6 @@
139140
--color-vscode-editorHoverWidget-foreground: var(--vscode-editorHoverWidget-foreground);
140141
--color-vscode-editorHoverWidget-background: var(--vscode-editorHoverWidget-background);
141142
--color-vscode-editorHoverWidget-border: var(--vscode-editorHoverWidget-border);
142-
143-
/**
144-
* VSCode tooltip shadow - matches native VSCode tooltip styling
145-
* Uses a subtle shadow for better visibility and depth
146-
*/
147-
--color-vscode-widget-shadow: var(--vscode-widget-shadow, rgba(0, 0, 0, 0.36));
148143
}
149144

150145
@layer base {

0 commit comments

Comments
 (0)