refactor: eliminate duplicate toolProtocol detection logic and make parameter required

- Extract toolProtocol variable once at protocol detection point (line 288)
- Remove duplicate detection logic at telemetry capture point (line 434)
- Make toolProtocol parameter required (not optional) in TelemetryService.captureToolUsage()
- Ensures consistent protocol detection and required telemetry data

Author: roomote

packages/telemetry/src/TelemetryService.ts

@@ -98,7 +98,7 @@ export class TelemetryService {
 		this.captureEvent(TelemetryEventName.MODE_SWITCH, { taskId, newMode })
 	}
 
-	public captureToolUsage(taskId: string, tool: string, toolProtocol?: string): void {
+	public captureToolUsage(taskId: string, tool: string, toolProtocol: string): void {
 		this.captureEvent(TelemetryEventName.TOOL_USED, { taskId, tool, toolProtocol })
 	}
 

src/core/assistant-message/presentAssistantMessage.ts

@@ -285,6 +285,7 @@ export async function presentAssistantMessage(cline: Task) {
 			// XML protocol tool calls NEVER have an ID (parsed from XML text).
 			const toolCallId = (block as any).id
 			const isNative = !!toolCallId
+			const toolProtocol = toolCallId ? "native" : "xml"
 
 			const pushToolResult = (content: ToolResponse) => {
 				if (isNative && toolCallId) {
@@ -430,9 +431,6 @@ export async function presentAssistantMessage(cline: Task) {
 
 			if (!block.partial) {
 				cline.recordToolUsage(block.name)
-				// Determine protocol: native if tool has an ID, otherwise XML
-				const toolCallId = (block as any).id
-				const toolProtocol = toolCallId ? "native" : "xml"
 				TelemetryService.instance.captureToolUsage(cline.taskId, block.name, toolProtocol)
 			}