overcomplicated and confusing

[mooock]

I was trying out a POC of using this app, and was aiming at using GPO to administrate. I do quite a bit of Powershell code daily and really had trouble finding out the connection between the functions. and design of all the possibilities. The function for including apps looked very complicatede and it must have been a nightmare to get right. i think a good approach instead would be to use Hash tables and switch statements to get rid of all those if/else

one other thing that would be great to improve is that each function are able to provide a output without references and dependencies to the main ps1. it was very hard to read out when you use script variables from one script and pass it to a function. If going for such approach i would think it was better to define all the global or script variables at the top of the main script, like the regpaths and static values that are reused.

for the include app function i recommend using PSOBJECT at output the same vaules no matter if it is a text file or GPO value. i really got confused why the function could not run by its own but found out half of the variables was set from the main script. the same goes for using return values. In powershell PSobject should provide the data another function uses, in your function i both outputs a object and return value.

the policy function would also benefit for using more of Bool statements instead of the change++ incremental for detecting changes between the uninstall reg and GPO value.

what i mean by confusing. is that i was sure the script didn't work as intented. but everything was up for me to not understand the logic behind using GPO. I think this complication comes from a lot of user request or features being build on top of a design that expanded over time..

for for me using GPO or setting the GPO override i really expected that it only used GPO settings. so it took me a while to understand i needed to write GPO inside the source list. also when adding apps to the whitelist it was really hard to understand why it didn't read this list. maybe the logging was a good idea to improve with more data.

as i could understand people has requested some sort of merge between GPO and config settings. this might overcomplicate things. its not clear what will oweride what, and what settings being used.

one last thing i recommend is that maybe simplify listpath param. so GPO is not needed if you already have set GPO override or start to add programs to the whitelist. if programs are added to the list it should be expected that the users is aiming at a GPO list

i did an approch for a change on the includeapp to get the same output as the list view. but didn't get the part to use a variable inside a foreach loop and also output objects. normally it is said if you use a string twice you should add it to a variable.

if ($GPOList) {
    $RegWhitelist = "HKLM:\SOFTWARE\Policies\Romanitho\Winget-AutoUpdate\WhiteList"
    if (Test-Path $RegWhitelist) {
        Get-Item -Path $RegWhitelist | Select-Object -ExpandProperty Property | ForEach-Object {
            ((Get-ItemProperty -Path $RegWhitelist -name $_).$_).trim()
        }
    }
}

[KnifMelti]

Hello @mooock and greetings from your neighbor (Skåne/Sweden)!
You're absolutely right in everything above (I think, just a novice in PS)...

...it really was a real nightmare for me to get that GPO administration right (and still it contains bugs, see #346) and the reason is that I'm a dinosaur (both in age and experience) and this was my first try in PowerShell at all (coming from BAT/CMD/ST Basic/AHK/VB).

The GPO Blacklist/Whitelist and the requirement to also fill in where you want to pull the list from came from me wanting to have more options to switch between sources without being forced to rewrite the GPO list if I changed back to GPO (pulling from URL both private and in my company at the moment)

And yes, this journey has been that of a lot of different requests/ideas over time, so it lacks the grand thought/rules to bind everything together...

...but it just works (for the most)! 😁

But, you're more than welcome to join us and improve the code base!

[mooock]

I would say its very awesome work you have done, with massive moving parts that could go wrong. i have also come from cmd and AHK. and see other doing powershell that transfer ways of doing stuff from other languages. but have some times spend time on starting functions from scratch and forced my selv to do powershell the most correct way. and see how other big guys does the work. It must also have taken very long to get that far as you did, i was very impressed of the ADMX files you did. as i think its very complicated as soon you start putting logic inside it and do all the references to the text files.

Remember in Powershell ISE you can use CTRL+J to bring up snippes for making stuff the right way. and you should really try the possibillities of hashtables and switch. and then end all you outputs with a PSCUSTOMOBJECT and don't use return. Return is normally something you use in combination with other languages or CMD. to pass true or false for an execution.

but recall one of my scripts that ended the same way with alot of if/else statements, i couldnt sleep at night because i tried to keep up with the logic, and everytime i ended up missing a option or possibility. so when i did a more compact function using switches it was a lot easier to continue working after some time of from a project.

i would guess if you leave the project for a longer periode it will get really hard for you to catch up on why you did specific things.

just reach out. maybe i can help on some smaller stuff. as i also have a lot to look into on my new job

[KnifMelti]

Thanks for all the proposed ways of coding in PS!
Using VSCode, will start to learn more about the possibilities in the IDE:

And @Romanitho already have proposed a more simple way of handling it (working on it?)...
...regarding keeping up with the logic, I've lost it since long (setting my hopes to @Romanitho ❤️)!

[Romanitho]

100% agree with you guys. We need to clean the code for sure. and any help is appreciated 😊
Just have a look from the first version to today... quite a lot of things implemented etc... so any good idea, help, skill,... is very welcome for this project.

[KnifMelti]

😁
Then - Winget-AutoUpdate-Install.ps1 - 34 lines
Now - Winget-AutoUpdate-Install.ps1 - 738 lines

[KnifMelti]

A small step, learning by doing... 🤪

$WAUConfigPath = 'HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Winget-AutoUpdate'
$WAUPolicies = Get-ItemProperty -Path 'HKLM:\SOFTWARE\Policies\Romanitho\Winget-AutoUpdate' -ErrorAction SilentlyContinue
$WAUConfig = Get-ItemProperty -Path $WAUConfigPath -ErrorAction SilentlyContinue

$WAUPolicies_HashTable = [ordered]@{
    "WAU_AzureBlobSASURL" = $WAUPolicies.WAU_AzureBlobSASURL
    "WAU_BypassListForUsers" = $WAUPolicies.WAU_BypassListForUsers
    "WAU_DisableAutoUpdate" = $WAUPolicies.WAU_DisableAutoUpdate
    "WAU_DoNotRunOnMetered" = $WAUPolicies.WAU_DoNotRunOnMetered
    "WAU_ListPath" = $WAUPolicies.WAU_ListPath
    "WAU_MaxLogFiles" = $WAUPolicies.WAU_MaxLogFiles
    "WAU_MaxLogSize" = $WAUPolicies.WAU_MaxLogSize
    "WAU_ModsPath" = $WAUPolicies.WAU_ModsPath
    "WAU_NotificationLevel" = $WAUPolicies.WAU_NotificationLevel
    "WAU_DesktopShortcut" = $WAUPolicies.WAU_DesktopShortcut
    "WAU_StartMenuShortcut" = $WAUPolicies.WAU_StartMenuShortcut
    "WAU_UpdatePrerelease" = $WAUPolicies.WAU_UpdatePrerelease
    "WAU_UpdatesAtLogon" = $WAUPolicies.WAU_UpdatesAtLogon
    "WAU_UpdatesAtTime" = $WAUPolicies.WAU_UpdatesAtTime
    "WAU_UpdatesInterval" = $WAUPolicies.WAU_UpdatesInterval
    "WAU_UserContext" = $WAUPolicies.WAU_UserContext
    "WAU_UseWhiteList" = $WAUPolicies.WAU_UseWhiteList
}

$WAUConfig_HashTable = [ordered]@{
    "WAU_AzureBlobSASURL" = $WAUConfig.WAU_AzureBlobSASURL
    "WAU_BypassListForUsers" = $WAUConfig.WAU_BypassListForUsers
    "WAU_DisableAutoUpdate" = $WAUConfig.WAU_DisableAutoUpdate
    "WAU_DoNotRunOnMetered" = $WAUConfig.WAU_DoNotRunOnMetered
    "WAU_ListPath" = $WAUConfig.WAU_ListPath
    "WAU_MaxLogFiles" = $WAUConfig.WAU_MaxLogFiles
    "WAU_MaxLogSize" = $WAUConfig.WAU_MaxLogSize
    "WAU_ModsPath" = $WAUConfig.WAU_ModsPath
    "WAU_NotificationLevel" = $WAUConfig.WAU_NotificationLevel
    "WAU_DesktopShortcut" = $WAUConfig.WAU_DesktopShortcut
    "WAU_StartMenuShortcut" = $WAUConfig.WAU_StartMenuShortcut
    "WAU_UpdatePrerelease" = $WAUConfig.WAU_UpdatePrerelease
    "WAU_UpdatesAtLogon" = $WAUConfig.WAU_UpdatesAtLogon
    "WAU_UpdatesAtTime" = $WAUConfig.WAU_UpdatesAtTime
    "WAU_UpdatesInterval" = $WAUConfig.WAU_UpdatesInterval
    "WAU_UserContext" = $WAUConfig.WAU_UserContext
    "WAU_UseWhiteList" = $WAUConfig.WAU_UseWhiteList
}

$WAUPolicies_HashTable.GetEnumerator() | ForEach-Object {
    $_.Value = $_.Value.TrimEnd(' ', '\', '/')
}

foreach ($Key in $WAUPolicies_HashTable.Keys)
{
    if ($null -ne $($WAUPolicies_HashTable[$Key]) -and ($($WAUPolicies_HashTable[$Key]) -ne $($WAUConfig_HashTable[$Key])))
    {
        switch ($Key)
        {
            "WAU_AzureBlobSASURL" {$null = (New-ItemProperty -Path $WAUConfigPath -Name $Key -Value $($WAUPolicies_HashTable[$Key]) -Force -Confirm:$false)}
            # Going through the rest if they don't fall under Default...
            "WAU_BypassListForUsers" {}
            "WAU_DisableAutoUpdate" {}
            "WAU_DoNotRunOnMetered" {}
            "WAU_ListPath" {}
            "WAU_MaxLogFiles" {}
            "WAU_MaxLogSize" {}
            "WAU_ModsPath" {}
            "WAU_NotificationLevel" {}
            "WAU_DesktopShortcut" {}
            "WAU_StartMenuShortcut" {}
            "WAU_UpdatePrerelease" {}
            "WAU_UpdatesAtLogon" {}
            "WAU_UpdatesAtTime" {}
            "WAU_UpdatesInterval" {}
            "WAU_UserContext" {}
            "WAU_UseWhiteList" {}
            Default {$null = (New-ItemProperty -Path $WAUConfigPath -Name $Key -Value $($WAUPolicies_HashTable[$Key]) -PropertyType DWord -Force -Confirm:$false)}
        }
    }
}

[mooock]

@KnifMelti This looks very smooth, and easy to read, but guess its hard to implement so it don't break the old logic.

[KnifMelti]

I think I have found the logic for it now, implemented 8 easy ones:

WAU_AzureBlobSASURL
WAU_DoNotRunOnMetered
WAU_ListPath
WAU_MaxLogFiles
WAU_MaxLogSize
WAU_ModsPath
WAU_NotificationLevel
WAU_UpdatePrerelease

$WAUConfigPath = 'HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Winget-AutoUpdate'
$WAUPolicies = Get-ItemProperty -Path 'HKLM:\SOFTWARE\Policies\Romanitho\Winget-AutoUpdate' -ErrorAction SilentlyContinue
$WAUConfig = Get-ItemProperty -Path $WAUConfigPath -ErrorAction SilentlyContinue

$WAUPolicies_HashTable = [ordered]@{
    "WAU_AzureBlobSASURL" = $WAUPolicies.WAU_AzureBlobSASURL
    "WAU_BypassListForUsers" = $WAUPolicies.WAU_BypassListForUsers
    "WAU_DesktopShortcut" = $WAUPolicies.WAU_DesktopShortcut
    "WAU_DisableAutoUpdate" = $WAUPolicies.WAU_DisableAutoUpdate
    "WAU_DoNotRunOnMetered" = $WAUPolicies.WAU_DoNotRunOnMetered
    "WAU_ListPath" = $WAUPolicies.WAU_ListPath
    "WAU_MaxLogFiles" = $WAUPolicies.WAU_MaxLogFiles
    "WAU_MaxLogSize" = $WAUPolicies.WAU_MaxLogSize
    "WAU_ModsPath" = $WAUPolicies.WAU_ModsPath
    "WAU_NotificationLevel" = $WAUPolicies.WAU_NotificationLevel
    "WAU_StartMenuShortcut" = $WAUPolicies.WAU_StartMenuShortcut
    "WAU_UpdatePrerelease" = $WAUPolicies.WAU_UpdatePrerelease
    "WAU_UpdatesAtLogon" = $WAUPolicies.WAU_UpdatesAtLogon
    "WAU_UpdatesAtTime" = $WAUPolicies.WAU_UpdatesAtTime
    "WAU_UpdatesInterval" = $WAUPolicies.WAU_UpdatesInterval
    "WAU_UserContext" = $WAUPolicies.WAU_UserContext
    "WAU_UseWhiteList" = $WAUPolicies.WAU_UseWhiteList
}

$WAUConfig_HashTable = [ordered]@{
    "WAU_AzureBlobSASURL" = $WAUConfig.WAU_AzureBlobSASURL
    "WAU_BypassListForUsers" = $WAUConfig.WAU_BypassListForUsers
    "WAU_DesktopShortcut" = $WAUConfig.WAU_DesktopShortcut
    "WAU_DisableAutoUpdate" = $WAUConfig.WAU_DisableAutoUpdate
    "WAU_DoNotRunOnMetered" = $WAUConfig.WAU_DoNotRunOnMetered
    "WAU_ListPath" = $WAUConfig.WAU_ListPath
    "WAU_MaxLogFiles" = $WAUConfig.WAU_MaxLogFiles
    "WAU_MaxLogSize" = $WAUConfig.WAU_MaxLogSize
    "WAU_ModsPath" = $WAUConfig.WAU_ModsPath
    "WAU_NotificationLevel" = $WAUConfig.WAU_NotificationLevel
    "WAU_StartMenuShortcut" = $WAUConfig.WAU_StartMenuShortcut
    "WAU_UpdatePrerelease" = $WAUConfig.WAU_UpdatePrerelease
    "WAU_UpdatesAtLogon" = $WAUConfig.WAU_UpdatesAtLogon
    "WAU_UpdatesAtTime" = $WAUConfig.WAU_UpdatesAtTime
    "WAU_UpdatesInterval" = $WAUConfig.WAU_UpdatesInterval
    "WAU_UserContext" = $WAUConfig.WAU_UserContext
    "WAU_UseWhiteList" = $WAUConfig.WAU_UseWhiteList
}

foreach ($Key in $WAUPolicies_HashTable.Keys)
{
    switch ($Key)
    {
        # AzureBlobSASURL
        "WAU_AzureBlobSASURL"
        {
            # If it isn't configured (or disabled) in GPO and Config is set to something
            if ($null -eq $($WAUPolicies_HashTable[$Key]) -and $null -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = Not Configured in GPO | $($WAUConfig_HashTable[$Key]) - Reset to Default"
                $null = (Remove-ItemProperty -Path $WAUConfigPath -Name $Key -Force -Confirm:$false)
            }
            # If enabled in GPO but different from Config
            elseif ($($WAUPolicies_HashTable[$Key]) -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = $($WAUPolicies_HashTable[$Key]) | $($WAUConfig_HashTable[$Key]) - Changing Value"
                $null = (New-ItemProperty -Path $WAUConfigPath -Name $Key -Value $($WAUPolicies_HashTable[$Key]) -Force -Confirm:$false)
            }
            # If same value (empty or not) in GPO as in Config
            else
            {
                Write-Host "$Key = Values are the same ($($WAUPolicies_HashTable[$Key]))"
            }
        }

        # BypassListForUsers
        "WAU_BypassListForUsers"
        {
            if ($null -eq $($WAUPolicies_HashTable[$Key]) -and $null -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = Not Configured in GPO | $($WAUConfig_HashTable[$Key]) - Reset to Default"
            }
            elseif ($($WAUPolicies_HashTable[$Key]) -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = $($WAUPolicies_HashTable[$Key]) | $($WAUConfig_HashTable[$Key]) - Changing Value"
            }
            else
            {
                Write-Host "$Key = Values are the same ($($WAUPolicies_HashTable[$Key]))"
            }
        }

        # DesktopShortcut
        "WAU_DesktopShortcut"
        {
            if ($null -eq $($WAUPolicies_HashTable[$Key]) -and $null -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = Not Configured in GPO | $($WAUConfig_HashTable[$Key]) - Reset to Default"
            }
            elseif ($($WAUPolicies_HashTable[$Key]) -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = $($WAUPolicies_HashTable[$Key]) | $($WAUConfig_HashTable[$Key]) - Changing Value"
            }
            else
            {
                Write-Host "$Key = Values are the same ($($WAUPolicies_HashTable[$Key]))"
            }
        }

        # DisableAutoUpdate
        "WAU_DisableAutoUpdate"
        {
            if ($null -eq $($WAUPolicies_HashTable[$Key]) -and $null -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = Not Configured in GPO | $($WAUConfig_HashTable[$Key]) - Reset to Default"
            }
            elseif ($($WAUPolicies_HashTable[$Key]) -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = $($WAUPolicies_HashTable[$Key]) | $($WAUConfig_HashTable[$Key]) - Changing Value"
            }
            else
            {
                Write-Host "$Key = Values are the same ($($WAUPolicies_HashTable[$Key]))"
            }
        }
        
        # DoNotRunOnMetered
        "WAU_DoNotRunOnMetered"
        {
            if ($null -eq $($WAUPolicies_HashTable[$Key]) -and $null -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = Not Configured in GPO | $($WAUConfig_HashTable[$Key])"
                if ($($WAUConfig_HashTable[$Key]) -ne 1)
                {
                    Write-Host "Reset $Key to Default (1)"
                    $null = (New-ItemProperty -Path $WAUConfigPath -Name $Key -Value 1 -PropertyType DWord -Force -Confirm:$false)
                }
            }
            elseif ($($WAUPolicies_HashTable[$Key]) -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = $($WAUPolicies_HashTable[$Key]) | $($WAUConfig_HashTable[$Key]) - Changing Value"
                $null = (New-ItemProperty -Path $WAUConfigPath -Name $Key -Value $($WAUPolicies_HashTable[$Key]) -PropertyType DWord -Force -Confirm:$false)
            }
            else
            {
                Write-Host "$Key = Values are the same ($($WAUPolicies_HashTable[$Key]))"
            }
        }

        # ListPath
        "WAU_ListPath"
        {
            if ($null -eq $($WAUPolicies_HashTable[$Key]) -and $null -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = Not Configured in GPO | $($WAUConfig_HashTable[$Key])"
                if ($($WAUConfig_HashTable[$Key]) -ne "")
                {
                    Write-Host "Reset $Key to Default ("""")"
                    $null = (New-ItemProperty -Path $WAUConfigPath -Name $Key -Value "" -Force -Confirm:$false)
                }
            }
            elseif ($($WAUPolicies_HashTable[$Key]) -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = $($WAUPolicies_HashTable[$Key]) | $($WAUConfig_HashTable[$Key]) - Changing Value"
                $null = (New-ItemProperty -Path $WAUConfigPath -Name $Key -Value $($WAUPolicies_HashTable[$Key]) -Force -Confirm:$false)
            }
            else
            {
                Write-Host "$Key = Values are the same ($($WAUPolicies_HashTable[$Key]))"
            }
        }

        # MaxLogFiles
        "WAU_MaxLogFiles"
        {
            if ($null -eq $($WAUPolicies_HashTable[$Key]) -and $null -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = Not Configured in GPO | $($WAUConfig_HashTable[$Key])"
                if ($($WAUConfig_HashTable[$Key]) -ne 3)
                {
                    Write-Host "Reset $Key to Default (3)"
                    $null = (New-ItemProperty -Path $WAUConfigPath -Name $Key -Value 3 -PropertyType DWord -Force -Confirm:$false)
                }
            }
            elseif ($($WAUPolicies_HashTable[$Key]) -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = $($WAUPolicies_HashTable[$Key]) | $($WAUConfig_HashTable[$Key]) - Changing Value"
                $null = (New-ItemProperty -Path $WAUConfigPath -Name $Key -Value $($WAUPolicies_HashTable[$Key]) -PropertyType DWord -Force -Confirm:$false)
            }
            else
            {
                Write-Host "$Key = Values are the same ($($WAUPolicies_HashTable[$Key]))"
            }
        }

        # MaxLogSize
        "WAU_MaxLogSize"
        {
            if ($null -eq $($WAUPolicies_HashTable[$Key]) -and $null -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = Not Configured in GPO | $($WAUConfig_HashTable[$Key])"
                if ($($WAUConfig_HashTable[$Key]) -ne 1048576)
                {
                    Write-Host "Reset $Key to Default (1048576)"
                    $null = (New-ItemProperty -Path $WAUConfigPath -Name $Key -Value 1048576 -PropertyType DWord -Force -Confirm:$false)
                }
            }
            elseif ($($WAUPolicies_HashTable[$Key]) -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = $($WAUPolicies_HashTable[$Key]) | $($WAUConfig_HashTable[$Key]) - Changing Value"
                $null = (New-ItemProperty -Path $WAUConfigPath -Name $Key -Value $($WAUPolicies_HashTable[$Key]) -PropertyType DWord -Force -Confirm:$false)
            }
            else
            {
                Write-Host "$Key = Values are the same ($($WAUPolicies_HashTable[$Key]))"
            }
        }

        # ModsPath
        "WAU_ModsPath"
        {
            if ($null -eq $($WAUPolicies_HashTable[$Key]) -and $null -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = Not Configured in GPO | $($WAUConfig_HashTable[$Key])"
                if ($($WAUConfig_HashTable[$Key]) -ne "")
                {
                    Write-Host "Reset $Key to Default ("""")"
                    $null = (New-ItemProperty -Path $WAUConfigPath -Name $Key -Value "" -Force -Confirm:$false)
                }
            }
            elseif ($($WAUPolicies_HashTable[$Key]) -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = $($WAUPolicies_HashTable[$Key]) | $($WAUConfig_HashTable[$Key]) - Changing Value"
                $null = (New-ItemProperty -Path $WAUConfigPath -Name $Key -Value $($WAUPolicies_HashTable[$Key]) -Force -Confirm:$false)
            }
            else
            {
                Write-Host "$Key = Values are the same ($($WAUPolicies_HashTable[$Key]))"
            }
        }

        # NotificationLevel
        "WAU_NotificationLevel"
        {
            if ($null -eq $($WAUPolicies_HashTable[$Key]) -and $null -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = Not Configured in GPO | $($WAUConfig_HashTable[$Key])"
                if ($($WAUConfig_HashTable[$Key]) -ne "Full")
                {
                    Write-Host "Reset $Key to Default (Full)"
                    $null = (New-ItemProperty -Path $WAUConfigPath -Name $Key -Value "Full" -Force -Confirm:$false)
                }
            }
            elseif ($($WAUPolicies_HashTable[$Key]) -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = $($WAUPolicies_HashTable[$Key]) | $($WAUConfig_HashTable[$Key]) - Changing Value"
                $null = (New-ItemProperty -Path $WAUConfigPath -Name $Key -Value $($WAUPolicies_HashTable[$Key]) -Force -Confirm:$false)
            }
            else
            {
                Write-Host "$Key = Values are the same ($($WAUPolicies_HashTable[$Key]))"
            }
        }

        # StartMenuShortcut
        "WAU_StartMenuShortcut"
        {
            if ($null -eq $($WAUPolicies_HashTable[$Key]) -and $null -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = Not Configured in GPO | $($WAUConfig_HashTable[$Key]) - Reset to Default"
            }
            elseif ($($WAUPolicies_HashTable[$Key]) -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = $($WAUPolicies_HashTable[$Key]) | $($WAUConfig_HashTable[$Key]) - Changing Value"
            }
            else
            {
                Write-Host "$Key = Values are the same ($($WAUPolicies_HashTable[$Key]))"
            }
        }

        # UpdatePrerelease
        "WAU_UpdatePrerelease"
        {
            if ($null -eq $($WAUPolicies_HashTable[$Key]) -and $null -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = Not Configured in GPO | $($WAUConfig_HashTable[$Key])"
                if ($($WAUConfig_HashTable[$Key]) -ne 0)
                {
                    Write-Host "Reset $Key to Default (0)"
                    $null = (New-ItemProperty -Path $WAUConfigPath -Name $Key -Value 0 -PropertyType DWord -Force -Confirm:$false)
                }
            }
            elseif ($($WAUPolicies_HashTable[$Key]) -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = $($WAUPolicies_HashTable[$Key]) | $($WAUConfig_HashTable[$Key]) - Changing Value"
                $null = (New-ItemProperty -Path $WAUConfigPath -Name $Key -Value $($WAUPolicies_HashTable[$Key]) -PropertyType DWord -Force -Confirm:$false)
            }
            else
            {
                Write-Host "$Key = Values are the same ($($WAUPolicies_HashTable[$Key]))"
            }
        }

        # UpdatesAtLogon
        "WAU_UpdatesAtLogon"
        {
            if ($null -eq $($WAUPolicies_HashTable[$Key]) -and $null -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = Not Configured in GPO | $($WAUConfig_HashTable[$Key]) - Reset to Default"
            }
            elseif ($($WAUPolicies_HashTable[$Key]) -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = $($WAUPolicies_HashTable[$Key]) | $($WAUConfig_HashTable[$Key]) - Changing Value"
            }
            else
            {
                Write-Host "$Key = Values are the same ($($WAUPolicies_HashTable[$Key]))"
            }
        }

        # UpdatesAtTime
        "WAU_UpdatesAtTime"
        {
            if ($null -eq $($WAUPolicies_HashTable[$Key]) -and $null -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = Not Configured in GPO | $($WAUConfig_HashTable[$Key]) - Reset to Default"
            }
            elseif ($($WAUPolicies_HashTable[$Key]) -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = $($WAUPolicies_HashTable[$Key]) | $($WAUConfig_HashTable[$Key]) - Changing Value"
            }
            else
            {
                Write-Host "$Key = Values are the same ($($WAUPolicies_HashTable[$Key]))"
            }
        }

        # UpdatesInterval
        "WAU_UpdatesInterval"
        {
            if ($null -eq $($WAUPolicies_HashTable[$Key]) -and $null -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = Not Configured in GPO | $($WAUConfig_HashTable[$Key]) - Reset to Default"
            }
            elseif ($($WAUPolicies_HashTable[$Key]) -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = $($WAUPolicies_HashTable[$Key]) | $($WAUConfig_HashTable[$Key]) - Changing Value"
            }
            else
            {
                Write-Host "$Key = Values are the same ($($WAUPolicies_HashTable[$Key]))"
            }
        }

        # UserContext
        "WAU_UserContext"
        {
            if ($null -eq $($WAUPolicies_HashTable[$Key]) -and $null -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = Not Configured in GPO | $($WAUConfig_HashTable[$Key]) - Reset to Default"
            }
            elseif ($($WAUPolicies_HashTable[$Key]) -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = $($WAUPolicies_HashTable[$Key]) | $($WAUConfig_HashTable[$Key]) - Changing Value"
            }
            else
            {
                Write-Host "$Key = Values are the same ($($WAUPolicies_HashTable[$Key]))"
            }
        }

        # UseWhiteList
        "WAU_UseWhiteList"
        {
            if ($null -eq $($WAUPolicies_HashTable[$Key]) -and $null -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = Not Configured in GPO | $($WAUConfig_HashTable[$Key]) - Reset to Default"
            }
            elseif ($($WAUPolicies_HashTable[$Key]) -ne $($WAUConfig_HashTable[$Key]))
            {
                Write-Host "$Key = $($WAUPolicies_HashTable[$Key]) | $($WAUConfig_HashTable[$Key]) - Changing Value"
            }
            else
            {
                Write-Host "$Key = Values are the same ($($WAUPolicies_HashTable[$Key]))"
            }
        }
    }
}

[Romanitho]

For me, we need to keep things as simple as possible.
So all settings that can be configured should be in registry.
Regarding settings on the scheduled task, as you said, it can be changed on next run of WAU :)

[KnifMelti]

Not sure if I understand the meaning of your latest comment...
...do you want a full management of all the settings in GPO or just the parts we can use REG to change?
Or do you want both ADMX, Winget-AutoUpdate/Winget-AutoUpdate-Light, to be included for users to choose for themselves?

[KnifMelti]

https://github.com/KnifMelti/Winget-AutoUpdate/tree/GPO-enhancements

[Romanitho]

In my opinion, only settings in the reg should be configurable to simplify things. Otherwise, we need to create a script that takes care of scheduled task changes and handle the way that WAU can be managed by GPO, then GPO can be deactivated, etc... too many cases to manage.
Whereas settings in the reg are easy to manage... we load the reg in a variable and change the values with the ones configured by GPO each time WAU runs.
I had made some Google search on the way we could change scheduled task with settings in the reg, but not possible natively 😅

[Romanitho]

Or, what we can do is: when GPO mode is activated, a small peace of script is created with a dedicated daily run scheduled task that manage WAU settings.
This way, changes on the scheduled tasks can be checked every day and we can manage everything.