Skip to content

fix: getAuthChain including the event itself #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 1 commit into from
Sep 15, 2025
Merged

fix: getAuthChain including the event itself #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions packages/room/src/state_resolution/definitions/definitions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,10 @@ export async function getAuthChain(
const eventId = event.eventId;

if (eventIdToAuthChainMap.has(eventId)) {
return eventIdToAuthChainMap.get(eventId);
return eventIdToAuthChainMap.get(eventId)!;
}

const authEvents = await event.getAuthorizationEvents(store);

if (authEvents.length === 0) {
eventIdToAuthChainMap.set(eventId, existingAuthChainPart);
return existingAuthChainPart;
Expand All @@ -130,8 +129,7 @@ export async function getAuthChain(
return newAuthChainPart;
};

const result = await _getAuthChain(event, new Set([event.eventId]));
return result || new Set<EventID>([event.eventId]);
return _getAuthChain(event, new Set([]));
}

// Auth difference
Expand All @@ -151,8 +149,11 @@ export async function getAuthChainDifference(
console.warn('event not found in store or remote', eventid);
continue;
}

for (const authChainEventId of await getAuthChain(event, store)) {
// TODO: deb check this I changed to keep the function behaving as the spec
for (const authChainEventId of [
...(await getAuthChain(event, store)),
event.eventId,
]) {
authChainForState.add(authChainEventId);
}
}
Expand Down