From 56622a35d04f2819132ad3b14c1e75a2bcc6b617 Mon Sep 17 00:00:00 2001 From: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com> Date: Fri, 9 Jan 2026 20:03:22 +0000 Subject: [PATCH] fix: ddp streamer not waiting some requests completion (#38118) --- .changeset/stale-shoes-serve.md | 5 +++++ ee/apps/account-service/src/lib/loginViaUsername.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/stale-shoes-serve.md diff --git a/.changeset/stale-shoes-serve.md b/.changeset/stale-shoes-serve.md new file mode 100644 index 0000000000000..6f1b6fea42ee2 --- /dev/null +++ b/.changeset/stale-shoes-serve.md @@ -0,0 +1,5 @@ +--- +'@rocket.chat/account-service': patch +--- + +Fixes an issue where some DDP streamer requests were returning before processing was completed diff --git a/ee/apps/account-service/src/lib/loginViaUsername.ts b/ee/apps/account-service/src/lib/loginViaUsername.ts index 67c4bd8c4c5e6..57f2cbb31ec08 100644 --- a/ee/apps/account-service/src/lib/loginViaUsername.ts +++ b/ee/apps/account-service/src/lib/loginViaUsername.ts @@ -15,7 +15,7 @@ export async function loginViaUsername( return false; } - const valid = user.services?.password?.bcrypt && validatePassword(password, user.services.password.bcrypt); + const valid = user.services?.password?.bcrypt && (await validatePassword(password, user.services.password.bcrypt)); if (!valid) { return false; }